Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: patch V8 to 9.5.172.25 #40604

Closed
wants to merge 1 commit into from
Closed

deps: patch V8 to 9.5.172.25 #40604

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Oct 26, 2021 •
edited
Loading

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Oct 26, 2021
@targos
Copy link
Member Author

targos commented Oct 26, 2021

It seems that V8's GitHub mirror was not updated in the last 6 days.
You can see the patches at https://chromium.googlesource.com/v8/v8.git/+log/refs/heads/9.5-lkgr/

@nodejs-github-bot

This comment has been minimized.

Sign in to view
This was referenced Oct 28, 2021
Open
Open
@targos targos changed the title deps: patch V8 to 9.5.172.24 deps: patch V8 to 9.5.172.25 Oct 29, 2021
@targos
Copy link
Member Author

targos commented Oct 29, 2021

Updated to 9.5.172.25

aduh95
aduh95 approved these changes Oct 29, 2021
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 29, 2021 •
edited by targos
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/40554/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4358/

This was referenced Oct 30, 2021
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40592/

This was referenced Nov 1, 2021
Open
Open
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 2, 2021 •
edited by targos
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/40652/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4368/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40661/

This was referenced Nov 3, 2021
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40724/

@github-actions github-actions bot mentioned this pull request Nov 6, 2021
Open
44 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40736/

@github-actions github-actions bot mentioned this pull request Nov 7, 2021
Open
46 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40750/

@github-actions github-actions bot mentioned this pull request Nov 8, 2021
Open
46 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40764/

@joyeecheung joyeecheung mentioned this pull request Nov 8, 2021
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40768/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40774/

targos added a commit that referenced this pull request Nov 8, 2021
@targos
deps: patch V8 to 9.5.172.25
df2fe87 
Refs: v8/v8@9.5.172.21...9.5.172.25

PR-URL: #40604
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos
Copy link
Member Author

targos commented Nov 8, 2021

Landed in df2fe87

@targos targos closed this Nov 8, 2021
@targos targos deleted the v8-95-update branch November 8, 2021 14:23
targos added a commit that referenced this pull request Nov 8, 2021
@targos
deps: patch V8 to 9.5.172.25
5bef743 
Refs: v8/v8@9.5.172.21...9.5.172.25

PR-URL: #40604
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos mentioned this pull request Nov 8, 2021
Merged
This was referenced Nov 9, 2021
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@targos @nodejs-github-bot @gengjiawen @aduh95