test: refactor flaky net-error-twice #4061
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was not reliably creating the error event on Windows 2012. This makes the test more robust by delaying the start of the server write until nextTick, allowing the connection to close and cause the error more reliably on Windows 2012. Fixes: nodejs#4057
Trott
added
net
|
Stress test without this fix: Stress test with this fix: |
|
(Oof, this does not fix. Will try something else.) |
|
you're a champion @Trott, thanks so much for chipping away at the flaky tests (with or without success), I'm sure everyone will appreciate it even without realising how much work goes in to fixing these |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was not reliably creating the error event on Windows 2012.
This makes the test more robust by delaying the destruction of the
socket until after data starts arriving rather than immediately upon
connection.
Fixes: #4057