Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: fix typos in lib code comments #40792

Merged
merged 3 commits into from
Nov 12, 2021
Merged

lib: fix typos in lib code comments #40792

merged 3 commits into from
Nov 12, 2021

Conversation

kuriyosh
Copy link
Contributor

This fixes three typos in lib dir code comment.

  • methdodmethod in lib/_http_incoming.js
  • catcheablecatchable in lib/events.js
  • instanceeinstance in lib/path.js

@nodejs-github-bot nodejs-github-bot added events Issues and PRs related to the events subsystem / EventEmitter. http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. path Issues and PRs related to the path subsystem. labels Nov 12, 2021
lib/_http_incoming.js Outdated Show resolved Hide resolved
@VoltrexKeyva
Copy link
Member

As per the review, welcome @kuriyosh! And thanks for the pull request.

Good catches there, did you find these typos by eyesight or by the help of a tool? If a tool; then which? It would be helpful for us to use these kinds of tools to find typos.

@VoltrexKeyva VoltrexKeyva removed the needs-ci PRs that need a full CI run. label Nov 12, 2021
@kuriyosh
Copy link
Contributor Author

kuriyosh commented Nov 12, 2021

@VoltrexMaster
Thank you for your quick review! The typo I added myself is fixed.

I used aspell which is a spell checker tool with a custom dictionary registered some words used in node.

@Mesteery Mesteery added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 12, 2021
@Ayase-252 Ayase-252 added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 12, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @Ayase-252. Please 👍 to approve.

@watilde watilde added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2021
@nodejs-github-bot
Copy link
Collaborator

@VoltrexKeyva
Copy link
Member

@watilde we shouldn't run full Jenkins CIs on changes that only apply on the documentation or comment changes as it does not affect the node binary builds, but one has already ran so; might need to remember that. 😄

@aduh95 aduh95 merged commit 69f487e into nodejs:master Nov 12, 2021
@aduh95
Copy link
Contributor

aduh95 commented Nov 12, 2021

Landed in 69f487e, thanks a lot for the contribution 🎉

targos pushed a commit that referenced this pull request Nov 21, 2021
PR-URL: #40792
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
PR-URL: #40792
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
PR-URL: #40792
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. events Issues and PRs related to the events subsystem / EventEmitter. fast-track PRs that do not need to wait for 48 hours to land. http Issues or PRs related to the http subsystem. path Issues and PRs related to the path subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants