Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: throw errors in SignTraits::DeriveBits #40796

Merged
merged 1 commit into from
Nov 15, 2021
Merged

crypto: throw errors in SignTraits::DeriveBits #40796

merged 1 commit into from
Nov 15, 2021
+28 −5

Conversation

tniessen
Copy link
Member

Throw OpenSSL errors instead of using a default error message. The default message is not helpful.

Fixes: #40794

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Nov 12, 2021
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@github-actions github-actions bot mentioned this pull request Nov 13, 2021
Open
31 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40855/

@tniessen tniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 13, 2021
This was referenced Nov 14, 2021
Open
Open
@tniessen
Copy link
Member Author

I am inclined to land this as a bug fix and not as a breaking change (cc @nodejs/crypto @jasnell).

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 15, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 15, 2021
@nodejs-github-bot nodejs-github-bot merged commit d049a52 into nodejs:master Nov 15, 2021
@nodejs-github-bot
Copy link
Collaborator

Landed in d049a52

This was referenced Nov 16, 2021
Open
Open
Open
targos pushed a commit that referenced this pull request Nov 21, 2021
@tniessen @targos
crypto: throw errors in SignTraits::DeriveBits
2979c58 
Fixes: #40794

PR-URL: #40796
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Nov 26, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
@tniessen @danielleadams
crypto: throw errors in SignTraits::DeriveBits
90ce19d 
Fixes: #40794

PR-URL: #40796
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@tniessen @danielleadams
crypto: throw errors in SignTraits::DeriveBits
e60841b 
Fixes: #40794

PR-URL: #40796
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@panva panva panva approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

crypto.sign swallows OpenSSL errors
5 participants
@tniessen @nodejs-github-bot @panva @jasnell @richardlau