Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: simplify major release preparation #40816

Merged
merged 1 commit into from
Dec 8, 2021
Merged

doc: simplify major release preparation #40816

merged 1 commit into from
Dec 8, 2021

Conversation

BethGriggs
Copy link
Member

Proposed simplification of the major release process.

Changes/rational:

  • Change the branch creation to two months prior from three months prior.
    • No builds are run until 6 weeks before so there's no significant impact of creating the branches any earlier.
  • Do not cherry-pick commits within the last month. Mirror the master branch up until 1 week before the release.
    • Mirroring the branches for as long as possible keeps the Git history in sync.
  • Dropped 'semver major cut-off' and replace with 'Inform TSC of any majors which land within a month of the release'.
    • Majors are already gated with TSC approvals at land time.
    • We've had almost no objections for majors for the past few releases - and when there is an objection we have almost always reverted on master too.
    • Asking if there's any objections to the majors is a somewhat tiresome process, and in recent releases I've found there has been minimal engagement. (We're all busy people and it is easy to miss notifications.)

cc: @nodejs/releasers @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 15, 2021
mcollina
mcollina approved these changes Nov 15, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

aduh95
aduh95 approved these changes Nov 15, 2021
View reviewed changes
doc/guides/releases.md Outdated Show resolved Hide resolved
@BethGriggs BethGriggs added the release-agenda Issues and PRs to discuss during the meetings of the Release team. label Nov 16, 2021
mhdawson
mhdawson approved these changes Nov 16, 2021
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BethGriggs BethGriggs mentioned this pull request Nov 17, 2021
Closed
@BethGriggs
doc: simplify major release preparation
068abb6 
Changes/rational:

- Change the branch creation to two months prior from three months prior
  to the release.
- Do not cherry-pick commits within the last month - mirror the master
  branch up until 1 week before the release.
- Dropped 'semver major cut-off' and replace with 'Inform TSC of any
  majors which land within a month of the release'.
@BethGriggs BethGriggs added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 8, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 8, 2021
@nodejs-github-bot nodejs-github-bot merged commit 18ff583 into nodejs:master Dec 8, 2021
@nodejs-github-bot
Copy link
Collaborator

Landed in 18ff583

danielleadams pushed a commit that referenced this pull request Dec 13, 2021
@BethGriggs @danielleadams
doc: simplify major release preparation
302d6ec 
Changes/rational:

- Change the branch creation to two months prior from three months prior
  to the release.
- Do not cherry-pick commits within the last month - mirror the master
  branch up until 1 week before the release.
- Dropped 'semver major cut-off' and replace with 'Inform TSC of any
  majors which land within a month of the release'.

PR-URL: #40816
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams pushed a commit that referenced this pull request Dec 14, 2021
@BethGriggs @danielleadams
doc: simplify major release preparation
e3ac384 
Changes/rational:

- Change the branch creation to two months prior from three months prior
  to the release.
- Do not cherry-pick commits within the last month - mirror the master
  branch up until 1 week before the release.
- Dropped 'semver major cut-off' and replace with 'Inform TSC of any
  majors which land within a month of the release'.

PR-URL: #40816
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@danielleadams danielleadams mentioned this pull request Dec 14, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@BethGriggs @danielleadams
doc: simplify major release preparation
2fbd3d9 
Changes/rational:

- Change the branch creation to two months prior from three months prior
  to the release.
- Do not cherry-pick commits within the last month - mirror the master
  branch up until 1 week before the release.
- Dropped 'semver major cut-off' and replace with 'Inform TSC of any
  majors which land within a month of the release'.

PR-URL: #40816
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@BethGriggs @danielleadams
doc: simplify major release preparation
a328f59 
Changes/rational:

- Change the branch creation to two months prior from three months prior
  to the release.
- Do not cherry-pick commits within the last month - mirror the master
  branch up until 1 week before the release.
- Dropped 'semver major cut-off' and replace with 'Inform TSC of any
  majors which land within a month of the release'.

PR-URL: #40816
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@BethGriggs @Linkgoron
doc: simplify major release preparation
73d608c 
Changes/rational:

- Change the branch creation to two months prior from three months prior
  to the release.
- Do not cherry-pick commits within the last month - mirror the master
  branch up until 1 week before the release.
- Dropped 'semver major cut-off' and replace with 'Inform TSC of any
  majors which land within a month of the release'.

PR-URL: nodejs#40816
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@BethGriggs @danielleadams
doc: simplify major release preparation
e401e6c 
Changes/rational:

- Change the branch creation to two months prior from three months prior
  to the release.
- Do not cherry-pick commits within the last month - mirror the master
  branch up until 1 week before the release.
- Dropped 'semver major cut-off' and replace with 'Inform TSC of any
  majors which land within a month of the release'.

PR-URL: #40816
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
@BethGriggs BethGriggs mentioned this pull request Mar 9, 2022
Merged
@RafaelGSS RafaelGSS mentioned this pull request Sep 13, 2022
Merged
@BethGriggs BethGriggs deleted the major-releases-edits branch March 6, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@mhdawson mhdawson mhdawson approved these changes

@danielleadams danielleadams danielleadams approved these changes

@richardlau richardlau richardlau approved these changes

@tniessen tniessen tniessen approved these changes

@ronag ronag ronag approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. release-agenda Issues and PRs to discuss during the meetings of the Release team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.