Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: document optional params in napi_get_cb_info #40821

Closed
wants to merge 1 commit into from

Conversation

mhdawson
Copy link
Member

No description provided.

Signed-off-by: Michael Dawson <mdawson@devrus.com>
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 15, 2021
@mhdawson
Copy link
Member Author

oops see there is extra stuff, fixing.

@mhdawson
Copy link
Member Author

Fixed

@Mesteery Mesteery added doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. and removed needs-ci PRs that need a full CI run. labels Nov 15, 2021
@mhdawson mhdawson changed the title Mark optional doc: document optional params in napi_get_cb_info Nov 15, 2021
@nodejs-github-bot
Copy link
Collaborator

@VoltrexKeyva
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/40927/

Is there a special/specific case where we should run full Jenkins CIs for documentation/comment changes? Because we usually don't run full Jenkins CIs on these types of changes.

@mhdawson
Copy link
Member Author

@VoltrexMaster good point, I was not thinking when I started it. The github actions were good enough.

@mhdawson
Copy link
Member Author

Going to land as required jobs for doc only changes have passed.

mhdawson added a commit that referenced this pull request Nov 19, 2021
Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #40821
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@mhdawson
Copy link
Member Author

Landed in a37b9c8

@mhdawson mhdawson closed this Nov 19, 2021
targos pushed a commit that referenced this pull request Nov 21, 2021
Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #40821
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #40821
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #40821
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants