Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add pref to using draft PR versus WIP label #40824

Merged
merged 3 commits into from
Nov 19, 2021

Conversation

mhdawson
Copy link
Member

  • add to the contribution guide that we prefer that
    people use draft PRs instead of the WIP label.

Signed-off-by: Michael Dawson mdawson@devrus.com

- add to the contribution guide that we prefer that
  people use draft PRs instead of the WIP label.

Signed-off-by: Michael Dawson <mdawson@devrus.com>
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 15, 2021
@mhdawson
Copy link
Member Author

Based on discussion in #33309

@BethGriggs
Copy link
Member

If I recall correctly, GH actions do not run on draft PRs - so I've often had to revert to using the 'WIP' label so I can check the tests results of something that is still in progress (for example, the major release proposals).

@bnb
Copy link
Contributor

bnb commented Nov 16, 2021

might be worth tracking this issue in the cli/cli repo (the official GitHub CLI) and updating these docs if that feature is ever shipped :)

@targos
Copy link
Member

targos commented Nov 16, 2021

If I recall correctly, GH actions do not run on draft PRs - so I've often had to revert to using the 'WIP' label so I can check the tests results of something that is still in progress (for example, the major release proposals).

We could think about adding a new label to force run GH actions on draft PRs.

mhdawson and others added 2 commits November 17, 2021 09:46
Co-authored-by: Rich Trott <rtrott@gmail.com>
Co-authored-by: Rich Trott <rtrott@gmail.com>
To get feedback on your proposed change even though it is not ready
to land, use the `Convert to draft` option in the GitHub UI.
Do not use the `wip` label as it might not prevent the PR
from landing before you are ready.
Copy link
Member

@ronag ronag Nov 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also I don't think wip stops GitHub ci from running

@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Nov 19, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 19, 2021
@nodejs-github-bot nodejs-github-bot merged commit 4a7a18b into nodejs:master Nov 19, 2021
@nodejs-github-bot
Copy link
Collaborator

Landed in 4a7a18b

targos pushed a commit that referenced this pull request Nov 21, 2021
- add to the contribution guide that we prefer that
  people use draft PRs instead of the WIP label.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #40824
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
- add to the contribution guide that we prefer that
  people use draft PRs instead of the WIP label.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #40824
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
- add to the contribution guide that we prefer that
  people use draft PRs instead of the WIP label.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #40824
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.