test: deflake fs-promises-watch #40863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the contents of the file every 100 milliseconds until the watcher notices the change. This is already done in the callback based version of the test (`test-fs-watch.js`). Fixes: nodejs#37637
nodejs-github-bot
added
needs-ci
|
Before: After: Thanks to @Linkgoron for the investigation. |
targos
approved these changes
Nov 19, 2021
Trott
approved these changes
Nov 19, 2021
github-actions
bot
removed
the
request-ci
Linkgoron
approved these changes
Nov 19, 2021
47 tasks
jasnell
approved these changes
Nov 20, 2021
41 tasks
ZYSzys
approved these changes
Nov 21, 2021
Trott
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in c6352f5 |
This was referenced Nov 22, 2021
targos
pushed a commit
that referenced
this pull request
Nov 26, 2021
Change the contents of the file every 100 milliseconds until the watcher notices the change. This is already done in the callback based version of the test (`test-fs-watch.js`). Fixes: #37637 PR-URL: #40863 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 30, 2022
Change the contents of the file every 100 milliseconds until the watcher notices the change. This is already done in the callback based version of the test (`test-fs-watch.js`). Fixes: #37637 PR-URL: #40863 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
Change the contents of the file every 100 milliseconds until the watcher notices the change. This is already done in the callback based version of the test (`test-fs-watch.js`). Fixes: #37637 PR-URL: #40863 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the contents of the file every 100 milliseconds until the watcher
notices the change. This is already done in the callback based version
of the test (
test-fs-watch.js).Fixes: #37637