-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: deflake cluster-concurrent-disconnect #40877
Merged
nodejs-github-bot
merged 1 commit into
nodejs:master
from
lpinca:deflake/cluster-concurrent-disconnect
Nov 21, 2021
Merged
test: deflake cluster-concurrent-disconnect #40877
nodejs-github-bot
merged 1 commit into
nodejs:master
from
lpinca:deflake/cluster-concurrent-disconnect
Nov 21, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
labels
Nov 19, 2021
Before:
After:
|
targos
approved these changes
Nov 19, 2021
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Nov 19, 2021
Trott
approved these changes
Nov 19, 2021
tniessen
approved these changes
Nov 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this only be lenient on mac?
I think it makes sense. Will update. |
Occasionally the error code is `'ENOTCONN'` on macOS. Add it as an allowed/expected code. Fixes: nodejs#38405
lpinca
force-pushed
the
deflake/cluster-concurrent-disconnect
branch
from
November 19, 2021 20:23
3bb5ba1
to
4e346e8
Compare
This was referenced Nov 20, 2021
ZYSzys
approved these changes
Nov 21, 2021
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Nov 21, 2021
tniessen
approved these changes
Nov 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating!
lpinca
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Nov 21, 2021
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Nov 21, 2021
Landed in 977877b |
This was referenced Nov 22, 2021
33 tasks
targos
pushed a commit
that referenced
this pull request
Nov 26, 2021
Occasionally the error code is `'ENOTCONN'` on macOS. Add it as an allowed/expected code. Fixes: #38405 PR-URL: #40877 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 30, 2022
Occasionally the error code is `'ENOTCONN'` on macOS. Add it as an allowed/expected code. Fixes: #38405 PR-URL: #40877 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
Occasionally the error code is `'ENOTCONN'` on macOS. Add it as an allowed/expected code. Fixes: #38405 PR-URL: #40877 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally the error code is
'ENOTCONN'
on macOS. Add it as anallowed/expected code.
Fixes: #38405