Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: deflake cluster-concurrent-disconnect #40877

Merged

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Nov 19, 2021

Occasionally the error code is 'ENOTCONN' on macOS. Add it as an
allowed/expected code.

Fixes: #38405

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 19, 2021
@lpinca
Copy link
Member Author

lpinca commented Nov 19, 2021

Before:

$ ./tools/test.py -J --repeat=1000 test/parallel/test-cluster-concurrent-disconnect.js 
=== release test-cluster-concurrent-disconnect ===                   
Path: parallel/test-cluster-concurrent-disconnect
node:assert:123
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
+ actual - expected

+ 'ENOTCONN'
- 'EPIPE'
    at Worker.<anonymous> (/Users/luigi/code/node/test/parallel/test-cluster-concurrent-disconnect.js:29:14)
    at Worker.emit (node:events:390:28)
    at ChildProcess.<anonymous> (node:internal/cluster/worker:30:12)
    at ChildProcess.emit (node:events:390:28)
    at node:internal/child_process:848:39
    at processTicksAndRejections (node:internal/process/task_queues:78:11) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 'ENOTCONN',
  expected: 'EPIPE',
  operator: 'strictEqual'
}

...

[02:12|% 100|+ 992|-   8]: Done

After:

$ ./tools/test.py -J --repeat=1000 test/parallel/test-cluster-concurrent-disconnect.js 
[02:14|% 100|+ 1000|-   0]: Done

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 19, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 19, 2021
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this only be lenient on mac?

@lpinca
Copy link
Member Author

lpinca commented Nov 19, 2021

Should this only be lenient on mac?

I think it makes sense. Will update.

Occasionally the error code is `'ENOTCONN'` on macOS. Add it as an
allowed/expected code.

Fixes: nodejs#38405
@ZYSzys ZYSzys added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 21, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 21, 2021
@nodejs-github-bot
Copy link
Collaborator

Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating!

@nodejs-github-bot
Copy link
Collaborator

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 21, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 21, 2021
@nodejs-github-bot nodejs-github-bot merged commit 977877b into nodejs:master Nov 21, 2021
@nodejs-github-bot
Copy link
Collaborator

Landed in 977877b

targos pushed a commit that referenced this pull request Nov 26, 2021
Occasionally the error code is `'ENOTCONN'` on macOS. Add it as an
allowed/expected code.

Fixes: #38405

PR-URL: #40877
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
Occasionally the error code is `'ENOTCONN'` on macOS. Add it as an
allowed/expected code.

Fixes: #38405

PR-URL: #40877
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
Occasionally the error code is `'ENOTCONN'` on macOS. Add it as an
allowed/expected code.

Fixes: #38405

PR-URL: #40877
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

investigate flaky test-cluster-concurrent-disconnect
6 participants