-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: deflake cluster-concurrent-disconnect #40877
test: deflake cluster-concurrent-disconnect #40877
Conversation
Before:
After:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this only be lenient on mac?
I think it makes sense. Will update. |
Occasionally the error code is `'ENOTCONN'` on macOS. Add it as an allowed/expected code. Fixes: nodejs#38405
3bb5ba1
to
4e346e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating!
Landed in 977877b |
Occasionally the error code is `'ENOTCONN'` on macOS. Add it as an allowed/expected code. Fixes: #38405 PR-URL: #40877 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Occasionally the error code is `'ENOTCONN'` on macOS. Add it as an allowed/expected code. Fixes: #38405 PR-URL: #40877 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Occasionally the error code is `'ENOTCONN'` on macOS. Add it as an allowed/expected code. Fixes: #38405 PR-URL: #40877 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Occasionally the error code is
'ENOTCONN'
on macOS. Add it as anallowed/expected code.
Fixes: #38405