-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
streams: fix enqueue race condition on esm modules #40901
Merged
nodejs-github-bot
merged 1 commit into
nodejs:master
from
RafaelGSS:fix/readable-web-stream
Dec 21, 2021
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
import { mustCall } from '../common/index.mjs'; | ||
import { ReadableStream } from 'stream/web'; | ||
import assert from 'assert'; | ||
|
||
{ | ||
// Test tee() with close in the nextTick after enqueue | ||
async function read(stream) { | ||
const chunks = []; | ||
for await (const chunk of stream) | ||
chunks.push(chunk); | ||
return Buffer.concat(chunks).toString(); | ||
} | ||
|
||
const [r1, r2] = new ReadableStream({ | ||
start(controller) { | ||
process.nextTick(() => { | ||
controller.enqueue(new Uint8Array([102, 111, 111, 98, 97, 114])); | ||
|
||
process.nextTick(() => { | ||
controller.close(); | ||
}); | ||
}); | ||
} | ||
}).tee(); | ||
|
||
(async () => { | ||
const [dataReader1, dataReader2] = await Promise.all([ | ||
read(r1), | ||
read(r2), | ||
]); | ||
|
||
assert.strictEqual(dataReader1, dataReader2); | ||
assert.strictEqual(dataReader1, 'foobar'); | ||
assert.strictEqual(dataReader2, 'foobar'); | ||
})().then(mustCall()); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I meant that opposite. I think https://github.com/nodejs/node/blob/master/lib/internal/streams/end-of-stream.js should be
queueMicrotask
instead ofprocess.nextTick
but I'm not sure 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a simple test by just calling
console.log
oneos
and it doesn't call, so not sure either if the end-of-stream is the best place. Looks like thekClose
is suitable for that otherwise my second comment #40901 (comment) is valid.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a comment here explaining that the addition of the process.nextTick is not part of the spec and why it's needed with a link back to the original issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.