-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf_hooks: use spec-compliant structuredClone
#40904
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serialize PerformanceMark's `detail` correctly. Fixes: nodejs#40840
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
util
Issues and PRs related to the built-in util module.
labels
Nov 21, 2021
targos
added
the
perf_hooks
Issues and PRs related to the implementation of the Performance Timing API.
label
Nov 21, 2021
benjamingr
approved these changes
Nov 21, 2021
cjihrig
approved these changes
Nov 21, 2021
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Nov 21, 2021
This comment has been minimized.
This comment has been minimized.
jasnell
approved these changes
Nov 21, 2021
BridgeAR
approved these changes
Nov 21, 2021
40 tasks
addaleax
approved these changes
Nov 22, 2021
45 tasks
This comment has been minimized.
This comment has been minimized.
45 tasks
This comment has been minimized.
This comment has been minimized.
38 tasks
This comment has been minimized.
This comment has been minimized.
33 tasks
This comment has been minimized.
This comment has been minimized.
27 tasks
VoltrexKeyva
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
and removed
needs-ci
PRs that need a full CI run.
labels
Nov 27, 2021
This was referenced Nov 28, 2021
targos
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Nov 29, 2021
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Nov 29, 2021
Landed in 42c0b2a |
danielleadams
pushed a commit
that referenced
this pull request
Dec 13, 2021
Serialize PerformanceMark's `detail` correctly. Fixes: #40840 PR-URL: #40904 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams
pushed a commit
that referenced
this pull request
Dec 14, 2021
Serialize PerformanceMark's `detail` correctly. Fixes: #40840 PR-URL: #40904 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos this causes |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
perf_hooks
Issues and PRs related to the implementation of the Performance Timing API.
util
Issues and PRs related to the built-in util module.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serialize PerformanceMark's
detail
correctly.Fixes: #40840