Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: ping TSC members identified as inactive #40915

Merged
merged 3 commits into from
Nov 24, 2021
Merged

tools: ping TSC members identified as inactive #40915

merged 3 commits into from
Nov 24, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 21, 2021

When detecting TSC members as inactive, @-mention them in the pull
request that moves them to emeritus. This notifies them in case the pull
request is in error.

@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Nov 21, 2021
@Trott
Copy link
Member Author

Trott commented Nov 21, 2021

If we want to 100% make sure this works, we can fast-track it, close #40908, and let this open a PR.

@Trott Trott requested a review from targos November 21, 2021 20:04
@targos
Copy link
Member

targos commented Nov 22, 2021

This lgtm, but it was mostly the next part of the message that I was interested in automating:

codebytere last attended a TSC meeting in September 2020. gabrielschulhof last attended a TSC meeting in May 2021. Neither have participated in recent votes.

@Trott
Copy link
Member Author

Trott commented Nov 24, 2021

This lgtm, but it was mostly the next part of the message that I was interested in automating:

codebytere last attended a TSC meeting in September 2020. gabrielschulhof last attended a TSC meeting in May 2021. Neither have participated in recent votes.

OK, I think this does something like that now. (I haven't tested it via an Action yet, but will run it when it lands and revise if necessary.)

@Trott
tools: ping TSC members identified as inactive
b5cebc7 
When detecting TSC members as inactive, @-mention them in the pull
request that moves them to emeritus. This notifies them in case the pull
request is in error.
@Trott
fixup! tools: ping TSC members identified as inactive
344c45d
@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 24, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 24, 2021
@nodejs-github-bot nodejs-github-bot merged commit f7ac6ba into nodejs:master Nov 24, 2021
@nodejs-github-bot
Copy link
Collaborator

Landed in f7ac6ba

@Trott Trott deleted the tsc-ping branch November 24, 2021 18:34
@aduh95
Copy link
Contributor

aduh95 commented Nov 25, 2021 •
edited
Loading

https://github.com/nodejs/node/runs/4315947355?check_suite_focus=true

Run gr2m/create-or-update-pull-request-action@v1
with:
    author: Node.js GitHub Bot <github-bot@iojs.org>
    branch: actions/inactive-tsc
    body: This PR was generated by tools/find-inactive-tsc.yml.
  
  @nodejs/tsc "@codebytere @gabrielschulhof"
  
  "Since 3 months ago, codebytere attended 0 out of 10 meetings and voted in 0 of 2 votes. Since 3 months ago, gabrielschulhof attended 0 out of 10 meetings and voted in 0 of 2 votes."
  
    commit-message: meta: move one or more TSC members to emeritus
    labels: meta
    title: meta: move one or more TSC members to emeritus
  env:
    NODE_VERSION: lts/*
    INACTIVE_TSC_HANDLES: "@codebytere @gabrielschulhof"
    DETAILS_FOR_COMMIT_BODY: "Since 3 months ago, codebytere attended 0 out of 10 meetings and voted in 0 of 2 votes. Since 3 months ago, gabrielschulhof attended 0 out of 10 meetings and voted in 0 of 2 votes."

The only nit would be to get rid of the " (maybe using fromJSON? not sure); other than that, LGTM.

@Trott
Copy link
Member Author

Trott commented Nov 25, 2021

The only nit would be to get rid of the " (maybe using fromJSON? not sure); other than that, LGTM.

I wonder if spaces aren't a problem in single-line GITHUB_ENV entries and we can just remove the quotation marks there.

@aduh95
Copy link
Contributor

aduh95 commented Nov 25, 2021

I don't know for GITHUB_ENV, but when using ::set-output quotes are not needed: https://github.com/nodejs/node/pull/40845/files#diff-f9aa500b86b242f58f185509ad323b3526cf5effc683df4b5cb4d78df4108c5fR15-R16

@Trott
Copy link
Member Author

Trott commented Nov 25, 2021

And if all else fails, we can use the multi-line HEREDOC format they support which doesn't require quotation marks or other punctuation around spaces.

@Trott
Copy link
Member Author

Trott commented Nov 25, 2021

(Testing now on my fork.)

Trott added a commit to Trott/io.js that referenced this pull request Nov 25, 2021
@Trott
build: remove extraneous quotation marks from commit body
0639453 
Refs: nodejs#40915 (comment)
@Trott
Copy link
Member Author

Trott commented Nov 25, 2021

Yup, leaving out the quotation marks worked. https://github.com/Trott/io.js/runs/4318829465?check_suite_focus=true (The failure is because I didn't set a needed token on my fork.)

PR coming momentarily.

Trott added a commit to Trott/io.js that referenced this pull request Nov 25, 2021
@Trott
build: remove extraneous quotation marks from commit body
fd39b2a 
Refs: nodejs#40915 (comment)
@Trott Trott mentioned this pull request Nov 25, 2021
Merged
nodejs-github-bot pushed a commit that referenced this pull request Nov 25, 2021
@Trott
build: remove extraneous quotation marks from commit body
78cc2bd 
Refs: #40915 (comment)

PR-URL: #40963
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Nov 26, 2021
@Trott @targos
tools: ping TSC members identified as inactive
0201f3f 
When detecting TSC members as inactive, @-mention them in the pull
request that moves them to emeritus. This notifies them in case the pull
request is in error.

PR-URL: #40915
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
targos pushed a commit that referenced this pull request Nov 26, 2021
@Trott @targos
build: remove extraneous quotation marks from commit body
65b33ba 
Refs: #40915 (comment)

PR-URL: #40963
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos mentioned this pull request Nov 26, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
@Trott @danielleadams
tools: ping TSC members identified as inactive
d227ed1 
When detecting TSC members as inactive, @-mention them in the pull
request that moves them to emeritus. This notifies them in case the pull
request is in error.

PR-URL: #40915
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
@Trott @danielleadams
build: remove extraneous quotation marks from commit body
39c233f 
Refs: #40915 (comment)

PR-URL: #40963
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Trott @danielleadams
tools: ping TSC members identified as inactive
da35d4f 
When detecting TSC members as inactive, @-mention them in the pull
request that moves them to emeritus. This notifies them in case the pull
request is in error.

PR-URL: #40915
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Trott @danielleadams
build: remove extraneous quotation marks from commit body
a905dfe 
Refs: #40915 (comment)

PR-URL: #40963
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mesteery Mesteery Mesteery left review comments

@BridgeAR BridgeAR BridgeAR approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@richardlau richardlau richardlau approved these changes

@targos targos targos approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Trott @targos @nodejs-github-bot @aduh95 @jasnell @richardlau @BethGriggs @BridgeAR @Mesteery