Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update BUILDING.md section on running tests #40933

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 23, 2021

Refs: #40920

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Nov 23, 2021
@VoltrexKeyva
Copy link
Member

LGTM except for the typo in the commit message title. :)

@Trott Trott changed the title doc: udpate BUILDING.md section on running tests doc: update BUILDING.md section on running tests Nov 23, 2021
@Trott
Copy link
Member Author

Trott commented Nov 23, 2021

LGTM except for the typo in the commit message title. :)

Whoops! Fixed.

Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize this was introduced prior to this PR, but shouldn't we be using bash instead of text? And shouldn't we avoid to name the python executable (which is named python3 in many systems I believe)?

BUILDING.md Outdated Show resolved Hide resolved
BUILDING.md Outdated Show resolved Hide resolved
BUILDING.md Show resolved Hide resolved
BUILDING.md Outdated Show resolved Hide resolved
BUILDING.md Outdated Show resolved Hide resolved
BUILDING.md Outdated Show resolved Hide resolved
BUILDING.md Outdated Show resolved Hide resolved
BUILDING.md Outdated Show resolved Hide resolved
@Trott Trott force-pushed the running-tests branch 6 times, most recently from 384f16f to 82851fd Compare November 23, 2021 15:15
@Trott
Copy link
Member Author

Trott commented Nov 23, 2021

@aduh95 I believe I've addressed all your suggestions. If I've missed something, please let me know!

BUILDING.md Outdated Show resolved Hide resolved
@Trott Trott force-pushed the running-tests branch 2 times, most recently from 442d353 to 82e292b Compare November 23, 2021 15:30
@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 25, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 25, 2021
@nodejs-github-bot nodejs-github-bot merged commit a5d3449 into nodejs:master Nov 25, 2021
@nodejs-github-bot
Copy link
Collaborator

Landed in a5d3449

@Trott Trott deleted the running-tests branch November 26, 2021 07:25
targos pushed a commit that referenced this pull request Nov 26, 2021
Refs: #40920

PR-URL: #40933
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
Refs: #40920

PR-URL: #40933
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
Refs: #40920

PR-URL: #40933
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants