-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: ignore unrelated workflow changes in slow Actions tests #40990
Merged
nodejs-github-bot
merged 2 commits into
nodejs:master
from
aduh95:no-more-build-for-actions-changes
Nov 30, 2021
Merged
tools: ignore unrelated workflow changes in slow Actions tests #40990
nodejs-github-bot
merged 2 commits into
nodejs:master
from
aduh95:no-more-build-for-actions-changes
Nov 30, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes in the workflow files never affect the node binary, running build tasks seems unnecessary. Refs: nodejs#40928
nodejs-github-bot
added
the
meta
Issues and PRs related to the general management of the project.
label
Nov 27, 2021
VoltrexKeyva
approved these changes
Nov 27, 2021
Mesteery
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Nov 27, 2021
targos
approved these changes
Nov 27, 2021
Trott
approved these changes
Nov 28, 2021
lpinca
approved these changes
Nov 28, 2021
targos
added
commit-queue
Add this label to land a pull request using GitHub Actions.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
labels
Nov 30, 2021
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Nov 30, 2021
Landed in d81f328 |
danielleadams
pushed a commit
that referenced
this pull request
Dec 13, 2021
Changes in the workflow files never affect the node binary, running build tasks seems unnecessary. Refs: #40928 PR-URL: #40990 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 14, 2021
Changes in the workflow files never affect the node binary, running build tasks seems unnecessary. Refs: #40928 PR-URL: #40990 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
Changes in the workflow files never affect the node binary, running build tasks seems unnecessary. Refs: #40928 PR-URL: #40990 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
Changes in the workflow files never affect the node binary, running build tasks seems unnecessary. Refs: nodejs#40928 PR-URL: nodejs#40990 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
Changes in the workflow files never affect the node binary, running build tasks seems unnecessary. Refs: #40928 PR-URL: #40990 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
meta
Issues and PRs related to the general management of the project.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in the workflow files never affect the node binary, running
build tasks seems unnecessary.
Refs: #40928