Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add usage recommendation for writable._destroy #41040

Merged
merged 1 commit into from
Dec 22, 2021
Merged

doc: add usage recommendation for writable._destroy #41040

merged 1 commit into from
Dec 22, 2021

Conversation

RafaelGSS
Copy link
Member

Address: #40377

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Nov 30, 2021
mcollina
mcollina approved these changes Nov 30, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina requested a review from ronag November 30, 2021 16:37
@lpinca
Copy link
Member

lpinca commented Nov 30, 2021

In light of #40773 is this still needed? I guess we should eventually revert this when #40773 lands.

@RafaelGSS
Copy link
Member Author

In light of #40773 is this still needed? I guess we should eventually revert this when #40773 lands.

I think that it still needs to be backported.

@RafaelGSS
Copy link
Member Author

Any updates on this?

@mcollina mcollina added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 22, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 22, 2021
@nodejs-github-bot nodejs-github-bot merged commit 5016181 into nodejs:master Dec 22, 2021
@nodejs-github-bot
Copy link
Collaborator

Landed in 5016181

@RafaelGSS RafaelGSS mentioned this pull request Dec 22, 2021
Closed
targos pushed a commit that referenced this pull request Jan 14, 2022
@RafaelGSS @targos
doc: add usage recommendation for writable._destroy
29563ab 
PR-URL: #41040
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@targos targos mentioned this pull request Jan 16, 2022
Merged
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@RafaelGSS @danielleadams
doc: add usage recommendation for writable._destroy
b8a7f63 
PR-URL: #41040
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@RafaelGSS @Linkgoron
doc: add usage recommendation for writable._destroy
36d9c08 
PR-URL: nodejs#41040
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@RafaelGSS @danielleadams
doc: add usage recommendation for writable._destroy
aa04a2c 
PR-URL: #41040
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bell47 bell47 bell47 approved these changes

@mcollina mcollina mcollina approved these changes

@ronag ronag Awaiting requested review from ronag

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RafaelGSS @lpinca @nodejs-github-bot @mcollina @bell47