fix withoutintl builds #41078
Merged
fix withoutintl builds #41078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent upgrade of highlight.js has broken the docs build on the withoutintl builds.
nodejs-github-bot
added
doc
richardlau
added
request-ci
|
Fast-track has been requested by @richardlau. Please 👍 to approve. |
github-actions
bot
removed
the
request-ci
aduh95
reviewed
Dec 3, 2021
| @@ -7,7 +7,7 @@ | |||
| "node": ">=14.8.0" | |||
| }, | |||
| "devDependencies": { | |||
| "highlight.js": "^11.3.1", | |||
| "highlight.js": "^11.2.0", | |||
There was a problem hiding this comment.
You meant to pin the version, right?
Suggested change
| "highlight.js": "^11.2.0", | |
| "highlight.js": "11.2.0", |
There was a problem hiding this comment.
This didn't start failing until #41036 was merged -- the newer highlight.js was published two months ago: https://www.npmjs.com/package/highlight.js
There was a problem hiding this comment.
aduh95
approved these changes
Dec 3, 2021
Trott
approved these changes
Dec 3, 2021
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in c802c4b |
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
Recent upgrade of highlight.js has broken the docs build on the withoutintl builds. PR-URL: nodejs#41078 Refs: nodejs#41077 Refs: nodejs#41036 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent upgrade of highlight.js has broken the docs build on the
withoutintl builds.
Refs: #41077
Refs: #41036
Consider this a quick fix to unblock the CI as the automated tooling will attempt to update again the next time it is run. It's getting late here on a Friday evening so maybe someone else can take a look and figure out if the break is due to highlight.js or something latent in Node.js/V8.