Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update lint-md-dependencies to rollup@2.60.2 vfile-reporter@7.0.3 #41081

Closed
wants to merge 2 commits into from
Closed

tools: update lint-md-dependencies to rollup@2.60.2 vfile-reporter@7.0.3 #41081

wants to merge 2 commits into from

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of lint-md-dependencies to rollup@2.60.2 vfile-reporter@7.0.3.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Dec 4, 2021
targos
targos approved these changes Dec 5, 2021
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that there are a lot of changes in comments. Could we remove the comments from the rollup output?

@Trott
Copy link
Member

Trott commented Dec 5, 2021

I see that there are a lot of changes in comments. Could we remove the comments from the rollup output?

We could use https://www.npmjs.com/package/rollup-plugin-cleanup. That involves adding another dependency to tools/lint-md/package.json. The module hasn't been updated in over a year. But it would probably work.

Another option is we could minify the output, but that will have the opposite effect of what I think you want because it would make diffs bigger and more difficult to review.

Trott added a commit to Trott/io.js that referenced this pull request Dec 5, 2021
@Trott
tools: strip comments from lint-md rollup output
c28aab1 
Refs: nodejs#41081 (comment)
@Trott Trott mentioned this pull request Dec 5, 2021
Merged
@Trott
Copy link
Member

Trott commented Dec 5, 2021

I see that there are a lot of changes in comments. Could we remove the comments from the rollup output?

We could use https://www.npmjs.com/package/rollup-plugin-cleanup. That involves adding another dependency to tools/lint-md/package.json. The module hasn't been updated in over a year. But it would probably work.

Another option is we could minify the output, but that will have the opposite effect of what I think you want because it would make diffs bigger and more difficult to review.

#41092

nodejs-github-bot pushed a commit that referenced this pull request Dec 7, 2021
@Trott
tools: strip comments from lint-md rollup output
c93a639 
Refs: #41081 (comment)

PR-URL: #41092
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
@Trott Trott closed this Dec 12, 2021
@Trott Trott deleted the actions/tools-update-lint-md-dependencies branch December 12, 2021 13:14
danielleadams pushed a commit that referenced this pull request Dec 13, 2021
@Trott @danielleadams
tools: strip comments from lint-md rollup output
6052b39 
Refs: #41081 (comment)

PR-URL: #41092
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
danielleadams pushed a commit that referenced this pull request Dec 14, 2021
@Trott @danielleadams
tools: strip comments from lint-md rollup output
40a773a 
Refs: #41081 (comment)

PR-URL: #41092
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@Trott @danielleadams
tools: strip comments from lint-md rollup output
3e41c35 
Refs: #41081 (comment)

PR-URL: #41092
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@Trott @danielleadams
tools: strip comments from lint-md rollup output
f045d8e 
Refs: #41081 (comment)

PR-URL: #41092
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@Trott @Linkgoron
tools: strip comments from lint-md rollup output
fa3b1f7 
Refs: nodejs#41081 (comment)

PR-URL: nodejs#41092
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Trott @danielleadams
tools: strip comments from lint-md rollup output
2c28f86 
Refs: #41081 (comment)

PR-URL: #41092
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nodejs-github-bot @Trott @targos