-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: move one or more collaborators to emeritus #41154
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would have been nice to collaborate on loaders design, especially since we still want to ensure that our still experimental API can meet the APM use case(s).
Adding @watson @nodejs/tsc |
@watson, do you think you'd be interested in getting re-involved? The @nodejs/loaders team could use more input from APM vendors/those versed in the subject. I'm not sure if anyone has yet, but I meant to reach out a while back to see how we could ensure that this use case, in particular, is well-supported. We're still a couple of iterations away from stabilizing custom module loading (our hooks system), so it's not too late for feedback/collaboration if you're willing to help out. It would be good to have your thoughts on our progress and also good to know what Elastic would need as far as hooks are concerned if they intend to support newer Node.js applications (those not using CommonJS as their module format). Please let us know; team membership is open to anyone interested in getting involved/contributing to this testing/feedback/re-engineering research & development loop we're in currently. I am also happy to dismiss my review as stale for any other reason, but if joining a new team is something you see yourself doing, Loaders might be one worth considering. 😉 |
Same. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@DerekNonGeneric I did already reach out to APMs. It was discussed at at least a couple Loaders team meetings. |
Automatically add `blocked` label for find-inactive-collaborators's PRs. Refs: nodejs#41154 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Now that #41155 has landed, this is no longer blocked. |
Commit Queue failed- Loading data for nodejs/node/pull/41154 ✔ Done loading data for nodejs/node/pull/41154 ----------------------------------- PR info ------------------------------------ Title meta: move one or more collaborators to emeritus (#41154) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/inactive-collaborators -> nodejs:master Labels doc, meta Commits 1 - meta: move one or more collaborators to emeritus Committers 1 - Node.js GitHub Bot PR-URL: https://github.com/nodejs/node/pull/41154 Reviewed-By: Derek Lewis Reviewed-By: Rich Trott Reviewed-By: Matteo Collina Reviewed-By: Antoine du Hamel Reviewed-By: Colin Ihrig Reviewed-By: Tobias Nießen Reviewed-By: Joyee Cheung Reviewed-By: Luigi Pinca Reviewed-By: Michael Dawson Reviewed-By: Richard Lau ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41154 Reviewed-By: Derek Lewis Reviewed-By: Rich Trott Reviewed-By: Matteo Collina Reviewed-By: Antoine du Hamel Reviewed-By: Colin Ihrig Reviewed-By: Tobias Nießen Reviewed-By: Joyee Cheung Reviewed-By: Luigi Pinca Reviewed-By: Michael Dawson Reviewed-By: Richard Lau -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 13 Dec 2021 04:09:33 GMT ✔ Approvals: 10 ✔ - Derek Lewis (@DerekNonGeneric): https://github.com/nodejs/node/pull/41154#pullrequestreview-829762431 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/41154#pullrequestreview-829778163 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/41154#pullrequestreview-829838497 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/41154#pullrequestreview-829909980 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/41154#pullrequestreview-830234258 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/41154#pullrequestreview-830564675 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/41154#pullrequestreview-832762876 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41154#pullrequestreview-833365737 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/41154#pullrequestreview-833427239 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/41154#pullrequestreview-833446593 ✖ GitHub CI is still running ℹ Green GitHub Actions CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1584867256 |
PR-URL: #41154 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Landed in 162e5a1 |
e5260eb
to
162e5a1
Compare
I've blocked Refs (in addition to the two reviews in this PR) |
PR-URL: #41154 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Richard Lau <rlau@redhat.com>
PR-URL: #41154 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Richard Lau <rlau@redhat.com>
PR-URL: #41154 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Richard Lau <rlau@redhat.com>
PR-URL: #41154 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Richard Lau <rlau@redhat.com>
PR-URL: nodejs#41154 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Richard Lau <rlau@redhat.com>
PR-URL: #41154 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Richard Lau <rlau@redhat.com>
This PR was generated by tools/find-inactive-collaborators.yml.