Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: include stack trace difference in ES modules #41157

Closed
wants to merge 1 commit into from
Closed

doc: include stack trace difference in ES modules #41157

wants to merge 1 commit into from

Conversation

thebergamo
Copy link
Contributor

This change highlihts in the docs difference between stack traces for CJS modules and ES Modules.

Fixes: #39787

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core. labels Dec 13, 2021
@thebergamo thebergamo changed the title doc: Include stack trace diff in ES Modules doc: include stack trace difference in ES modules Dec 13, 2021
@thebergamo thebergamo changed the title doc: include stack trace difference in ES modules doc: include stack trace differecences in ES Modules Dec 13, 2021
aduh95
aduh95 reviewed Dec 13, 2021
View reviewed changes
doc/api/errors.md Outdated Show resolved Hide resolved
doc/api/errors.md Outdated Show resolved Hide resolved
@thebergamo
doc: include stack trace difference in ES modules
e0993f3 
This change highlights in the docs difference between stack traces for
CommonJS modules and ES Modules.

Fixes: nodejs#39787
@thebergamo
Copy link
Contributor Author

I wasn't sure which commit message I should use in case of accepting those changes you proposed @aduh95 so I just made them in my code and pushed.

@mscdex mscdex changed the title doc: include stack trace differecences in ES Modules doc: include stack trace difference in ES modules Dec 13, 2021
@aduh95
Copy link
Contributor

aduh95 commented Dec 15, 2021

/cc @nodejs/modules

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. review wanted PRs that need reviews. labels Dec 17, 2021
jasnell pushed a commit that referenced this pull request Dec 24, 2021
@thebergamo @jasnell
doc: include stack trace difference in ES modules
1e34969 
This change highlights in the docs difference between stack traces for
CommonJS modules and ES Modules.

Fixes: #39787

PR-URL: #41157
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Dec 24, 2021

Landed in 1e34969

@jasnell jasnell closed this Dec 24, 2021
targos pushed a commit that referenced this pull request Jan 14, 2022
@thebergamo @targos
doc: include stack trace difference in ES modules
e819685 
This change highlights in the docs difference between stack traces for
CommonJS modules and ES Modules.

Fixes: #39787

PR-URL: #41157
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Jan 16, 2022
Merged
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@thebergamo @danielleadams
doc: include stack trace difference in ES modules
6de10b0 
This change highlights in the docs difference between stack traces for
CommonJS modules and ES Modules.

Fixes: #39787

PR-URL: #41157
Reviewed-By: James M Snell <jasnell@gmail.com>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@thebergamo @Linkgoron
doc: include stack trace difference in ES modules
d254fc9 
This change highlights in the docs difference between stack traces for
CommonJS modules and ES Modules.

Fixes: nodejs#39787

PR-URL: nodejs#41157
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@thebergamo @danielleadams
doc: include stack trace difference in ES modules
9eb8233 
This change highlights in the docs difference between stack traces for
CommonJS modules and ES Modules.

Fixes: #39787

PR-URL: #41157
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 left review comments

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core. review wanted PRs that need reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doc: file url in stack traces contains file://
4 participants
@thebergamo @aduh95 @jasnell @nodejs-github-bot