v17.3.0 release proposal

.eslintrc.js

@@ -15,6 +15,7 @@ NodePlugin.RULES_DIR = path.resolve(__dirname, 'tools', 'eslint-rules');
 const ModuleFindPath = Module._findPath;
 const hacks = [
   'eslint-plugin-node-core',
+  'eslint-plugin-jsdoc',
   'eslint-plugin-markdown',
   '@babel/eslint-parser',
   '@babel/plugin-syntax-import-assertions',
@@ -34,7 +35,8 @@ Module._findPath = (request, paths, isMain) => {
 
 module.exports = {
   root: true,
-  plugins: ['markdown', 'node-core'],
+  extends: ['plugin:jsdoc/recommended'],
+  plugins: ['jsdoc', 'markdown', 'node-core'],
   parser: '@babel/eslint-parser',
   parserOptions: {
     babelOptions: {
@@ -336,6 +338,20 @@ module.exports = {
     'use-isnan': 'error',
     'valid-typeof': ['error', { requireStringLiterals: true }],
 
+    // JSDoc rules
+    'jsdoc/require-jsdoc': 'off',
+    'jsdoc/require-param-description': 'off',
+    'jsdoc/newline-after-description': 'off',
+    'jsdoc/require-returns-description': 'off',
+    'jsdoc/valid-types': 'off',
+    'jsdoc/no-undefined-types': 'off',
+    'jsdoc/require-param': 'off',
+    'jsdoc/check-tag-names': 'off',
+    'jsdoc/require-returns': 'off',
+    'jsdoc/require-property-description': 'off',
+    'jsdoc/check-param-names': 'off',
+    'jsdoc/tag-lines': 'off',
+
     // Custom rules from eslint-plugin-node-core
     'node-core/no-unescaped-regexp-dot': 'error',
     'node-core/no-duplicate-requires': 'error',

.github/SUPPORT.md

@@ -15,7 +15,6 @@ If you didn't find an answer in the resources above, try these unofficial
 resources:
 
 * [Questions tagged 'node.js' on Stack Overflow](https://stackoverflow.com/questions/tagged/node.js)
-* [#nodejs](https://openjs-foundation.slack.com/archives/CK9Q4MB53) channel on the OpenJS Foundation Slack ([join here](https://slack-invite.openjsf.org/))
 * [#node.js channel on libera.chat](https://web.libera.chat?channels=node.js&uio=d4)
 * [Node.js Slack Community](https://node-js.slack.com/)
   * To register: [nodeslackers.com](https://www.nodeslackers.com/)

.github/workflows/authors.yml

@@ -14,6 +14,7 @@ jobs:
       - uses: actions/checkout@v2
         with:
           fetch-depth: '0'  # This is required to actually get all the authors
+          persist-credentials: false
       - run: "tools/update-authors.js"  # Run the AUTHORS tool
       - uses: gr2m/create-or-update-pull-request-action@v1  # Create a PR or update the Action's existing PR
         env:

.github/workflows/auto-start-ci.yml

@@ -17,6 +17,8 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
+        with:
+          persist-credentials: false
 
       # Install dependencies
       - name: Install Node.js
@@ -26,40 +28,17 @@ jobs:
       - name: Install node-core-utils
         run: npm install -g node-core-utils
 
-      - name: Set variables
-        run: |
-          echo "REPOSITORY=$(echo ${{ github.repository }} | cut -d/ -f2)" >> $GITHUB_ENV
-          echo "OWNER=${{ github.repository_owner }}" >> $GITHUB_ENV
-
-      # Get Pull Requests
-      - name: Get Pull Requests
-        uses: octokit/graphql-action@v2.x
-        id: get_prs_for_ci
-        with:
-          query: |
-            query prs($owner:String!, $repo:String!) {
-              repository(owner:$owner, name:$repo) {
-                pullRequests(labels: ["request-ci"], states: OPEN, last: 100) {
-                  nodes {
-                    number
-                  }
-                }
-              }
-            }
-          owner: ${{ env.OWNER }}
-          repo: ${{ env.REPOSITORY }}
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-
       - name: Setup node-core-utils
         run: |
           ncu-config set username ${{ secrets.JENKINS_USER }}
           ncu-config set token none
           ncu-config set jenkins_token ${{ secrets.JENKINS_TOKEN }}
-          ncu-config set owner ${{ env.OWNER }}
-          ncu-config set repo ${{ env.REPOSITORY }}
+          ncu-config set owner "${{ github.repository_owner }}"
+          ncu-config set repo "$(echo ${{ github.repository }} | cut -d/ -f2)"
 
-      - name: Start CI
-        run: ./tools/actions/start-ci.sh $(echo '${{ steps.get_prs_for_ci.outputs.data }}' | jq '.repository.pullRequests.nodes | map(.number) | .[]')
+      - name: Start the CI
+        run: |
+          PRs=$(gh pr list --label 'request-ci' --json number --jq 'map(.number) | .[]' --limit 100)
+          ./tools/actions/start-ci.sh "$PRs"
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/build-tarball.yml

@@ -8,6 +8,8 @@ on:
       - '**.md'
       - 'AUTHORS'
       - 'doc/**'
+      - .github/**
+      - '!.github/workflows/build-tarball.yml'
   push:
     branches:
       - master
@@ -19,6 +21,8 @@ on:
       - '**.md'
       - 'AUTHORS'
       - 'doc/**'
+      - .github/**
+      - '!.github/workflows/build-tarball.yml'
 
 env:
   FLAKY_TESTS: dontcare
@@ -31,6 +35,8 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
+        with:
+          persist-credentials: false
       - name: Set up Python ${{ env.PYTHON_VERSION }}
         uses: actions/setup-python@v2
         with:
@@ -46,7 +52,7 @@ jobs:
           mkdir tarballs
           mv *.tar.gz tarballs
       - name: Upload tarball artifact
-        uses: actions/upload-artifact@v1
+        uses: actions/upload-artifact@v2
         with:
           name: tarballs
           path: tarballs
@@ -57,16 +63,19 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
+        with:
+          persist-credentials: false
       - name: Set up Python ${{ env.PYTHON_VERSION }}
         uses: actions/setup-python@v2
         with:
           python-version: ${{ env.PYTHON_VERSION }}
       - name: Environment Information
         run: npx envinfo
       - name: Download tarball
-        uses: actions/download-artifact@v1
+        uses: actions/download-artifact@v2
         with:
           name: tarballs
+          path: tarballs
       - name: Extract tarball
         run: |
           tar xzf tarballs/*.tar.gz -C $RUNNER_TEMP

.github/workflows/build-windows.yml

@@ -4,6 +4,8 @@ on:
   pull_request:
     paths-ignore:
       - "README.md"
+      - .github/**
+      - '!.github/workflows/build-windows.yml'
     types: [opened, synchronize, reopened, ready_for_review]
   push:
     branches:
@@ -14,6 +16,8 @@ on:
       - v[0-9]+.x
     paths-ignore:
       - "README.md"
+      - .github/**
+      - '!.github/workflows/build-windows.yml'
 
 env:
   PYTHON_VERSION: '3.10'
@@ -29,6 +33,8 @@ jobs:
     runs-on: ${{ matrix.windows }}
     steps:
       - uses: actions/checkout@v2
+        with:
+          persist-credentials: false
       - name: Set up Python ${{ env.PYTHON_VERSION }}
         uses: actions/setup-python@v2
         with:

.github/workflows/close-stalled.yml

@@ -8,7 +8,7 @@ jobs:
     if: github.repository == 'nodejs/node'
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/stale@v3
+      - uses: actions/stale@v4
         with:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
           days-before-close: 30

.github/workflows/comment-labeled.yml

@@ -12,12 +12,9 @@ jobs:
     steps:
       - name: Post stalled comment
         env:
-          COMMENTS_URL: ${{ github.event.issue.comments_url || github.event.pull_request.comments_url }}
-        run: |
-          curl -X POST $COMMENTS_URL \
-          -H "Content-Type: application/json" \
-          -H "Authorization: token ${{ secrets.GITHUB_TOKEN }}" \
-          --data '{ "body": "This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open." }'
+          NUMBER: ${{ github.event.issue.number || github.event.pull_request.number }}
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: gh issue comment "$NUMBER" --repo ${{ github.repository }} --body "This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open."
 
   fastTrack:
     if: github.repository == 'nodejs/node' && github.event_name == 'pull_request_target' && github.event.label.name == 'fast-track'

.github/workflows/commit-lint.yml

@@ -17,6 +17,7 @@ jobs:
       - uses: actions/checkout@v2
         with:
           fetch-depth: ${{ steps.nb-of-commits.outputs.plusOne }}
+          persist-credentials: false
       - run: git reset HEAD^2
       - name: Install Node.js
         uses: actions/setup-node@v2

.github/workflows/commit-queue.yml

@@ -46,27 +46,6 @@ jobs:
           echo "OWNER=${{ github.repository_owner }}" >> $GITHUB_ENV
           echo "DEFAULT_BRANCH=${GITHUB_REF#refs/heads/}" >> $GITHUB_ENV
 
-      - name: Get Pull Requests
-        uses: octokit/graphql-action@v2.x
-        id: get_mergable_pull_requests
-        with:
-          query: |
-            query release($owner:String!,$repo:String!, $base_ref:String!) {
-              repository(owner:$owner, name:$repo) {
-                pullRequests(baseRefName: $base_ref, labels: ["commit-queue"], states: OPEN, last: 100) {
-                  nodes {
-                    number
-                  }
-                }
-              }
-            }
-          owner: ${{ env.OWNER }}
-          repo: ${{ env.REPOSITORY }}
-          # Commit queue is only enabled for the default branch on the repository
-          base_ref: ${{ env.DEFAULT_BRANCH }}
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-
       - name: Configure node-core-utils
         run: |
           ncu-config set branch ${DEFAULT_BRANCH}
@@ -77,7 +56,13 @@ jobs:
           ncu-config set repo "${REPOSITORY}"
           ncu-config set owner "${OWNER}"
 
-      - name: Start the commit queue
-        run: ./tools/actions/commit-queue.sh ${OWNER} ${REPOSITORY} $(echo '${{ steps.get_mergable_pull_requests.outputs.data }}' | jq '.repository.pullRequests.nodes | map(.number) | .[]')
+      - name: Start the Commit Queue
+        run: |
+          PRs=$(gh pr list \
+                  --base ${{ env.DEFAULT_BRANCH }} \
+                  --label 'commit-queue' \
+                  --json number --jq 'map(.number) | .[]' \
+                  --limit 100)
+          ./tools/actions/commit-queue.sh ${{ env.OWNER }} ${{ env.REPOSITORY }} "$PRs"
         env:
           GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }}

.github/workflows/coverage-linux.yml

@@ -8,6 +8,8 @@ on:
       - 'benchmark/**'
       - 'deps/**'
       - 'doc/**'
+      - .github/**
+      - '!.github/workflows/coverage-linux.yml'
   push:
     branches:
       - master
@@ -17,6 +19,8 @@ on:
       - 'benchmark/**'
       - 'deps/**'
       - 'doc/**'
+      - .github/**
+      - '!.github/workflows/coverage-linux.yml'
 
 env:
   PYTHON_VERSION: '3.10'
@@ -28,6 +32,8 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
+        with:
+          persist-credentials: false
       - name: Set up Python ${{ env.PYTHON_VERSION }}
         uses: actions/setup-python@v2
         with:

.github/workflows/coverage-windows.yml

@@ -9,6 +9,8 @@ on:
       - 'deps/**'
       - 'doc/**'
       - 'tools/**'
+      - .github/**
+      - '!.github/workflows/coverage-windows.yml'
   push:
     branches:
       - master
@@ -19,6 +21,8 @@ on:
       - 'deps/**'
       - 'doc/**'
       - 'tools/**'
+      - .github/**
+      - '!.github/workflows/coverage-windows.yml'
 
 env:
   PYTHON_VERSION: '3.10'
@@ -30,6 +34,8 @@ jobs:
     runs-on: windows-latest
     steps:
       - uses: actions/checkout@v2
+        with:
+          persist-credentials: false
       - name: Set up Python ${{ env.PYTHON_VERSION }}
         uses: actions/setup-python@v2
         with:

.github/workflows/daily.yml

@@ -15,6 +15,8 @@ jobs:
     container: gcc:11
     steps:
       - uses: actions/checkout@v2
+        with:
+          persist-credentials: false
       - name: Use Node.js ${{ env.NODE_VERSION }}
         uses: actions/setup-node@v2
         with:

.github/workflows/find-inactive-collaborators.yml

@@ -9,7 +9,6 @@ on:
 
 env:
   NODE_VERSION: lts/*
-  NUM_COMMITS: 5000
 
 jobs:
   find:
@@ -19,15 +18,16 @@ jobs:
     steps:
       - uses: actions/checkout@v2
         with:
-          fetch-depth: ${{ env.NUM_COMMITS }}
+          fetch-depth: 0
+          persist-credentials: false
 
       - name: Use Node.js ${{ env.NODE_VERSION }}
         uses: actions/setup-node@v2
         with:
           node-version: ${{ env.NODE_VERSION }}
 
       - name: Find inactive collaborators
-        run: tools/find-inactive-collaborators.mjs ${{ env.NUM_COMMITS }}
+        run: tools/find-inactive-collaborators.mjs
 
       - name: Open pull request
         uses: gr2m/create-or-update-pull-request-action@v1

.github/workflows/find-inactive-tsc.yml

@@ -18,13 +18,16 @@ jobs:
     steps:
       - name: Checkout the repo
         uses: actions/checkout@v2
+        with:
+          persist-credentials: false
 
       - name: Clone nodejs/TSC repository
         uses: actions/checkout@v2
         with:
           fetch-depth: 0
-          repository: nodejs/TSC
           path: .tmp
+          persist-credentials: false
+          repository: nodejs/TSC
 
       - name: Use Node.js ${{ env.NODE_VERSION }}
         uses: actions/setup-node@v2

.github/workflows/license-builder.yml

@@ -12,6 +12,8 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
+        with:
+          persist-credentials: false
       - run: "./tools/license-builder.sh"  # Run the license builder tool
       - uses: gr2m/create-or-update-pull-request-action@v1.x  # Create a PR or update the Action's existing PR
         env: