async_hooks: fix AsyncLocalStorage in unhandledRejection cases #41202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmeck
added
confirmed-bug
nodejs-github-bot
added
needs-ci
jasnell
approved these changes
Dec 17, 2021
|
there is some kind of bug with the async id stack with this PR, DO NOT MERGE yet |
vdeturckheim
approved these changes
Dec 17, 2021
There was a problem hiding this comment.
LGTM with the call stack issues to be fixed. This would actually help me for implementing an idea I have for #40954
|
@bmeck does that mean only the tests are broken and not the actual feature? |
|
@vdeturckheim the feature isn't fully fixed it looks like, if you register |
|
@Qard please re-review |
Qard
reviewed
Dec 20, 2021
Qard
approved these changes
Dec 21, 2021
JungMinu
approved these changes
Dec 21, 2021
bmeck
added
author ready
|
Landed in c3866b0 |
bmeck
added a commit
that referenced
this pull request
Dec 21, 2021
PR-URL: #41202 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
This was referenced Dec 22, 2021
targos
pushed a commit
that referenced
this pull request
Jan 14, 2022
PR-URL: #41202 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
PR-URL: #41202 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
PR-URL: nodejs#41202 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
PR-URL: #41202 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now async local storage doesn't properly propagate through unhandledRejections. This fixes that.