Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: fix CQ and auto-start-ci jobs #41230

Merged
merged 1 commit into from
Dec 18, 2021
Merged

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Dec 18, 2021

My mistake, in #41193 I added undesirable quotes, which break the CQ and CI GH Actions jobs.

@aduh95 aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 18, 2021
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@github-actions
Copy link
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Dec 18, 2021
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 18, 2021
@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 18, 2021
PR-URL: nodejs#41230
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented Dec 18, 2021

Landed in 10df3af

@Trott Trott merged commit 10df3af into nodejs:master Dec 18, 2021
@aduh95 aduh95 deleted the fix-cq-and-request-ci branch December 18, 2021 14:08
targos pushed a commit that referenced this pull request Jan 14, 2022
PR-URL: #41230
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
PR-URL: #41230
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
PR-URL: nodejs#41230
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
PR-URL: #41230
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants