src: do IWYU for some STL includes #41236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
RaisinTen
reviewed
Dec 19, 2021
dsanders11
force-pushed
the
trim-includes
branch
from
b214e92
to
10116df
Compare
dsanders11
changed the title
dsanders11
force-pushed
the
trim-includes
branch
from
10116df
to
7d5e00e
Compare
dsanders11
force-pushed
the
trim-includes
branch
from
7d5e00e
to
e56fd04
Compare
RaisinTen
approved these changes
Dec 19, 2021
This comment has been minimized.
This comment has been minimized.
RaisinTen
added
the
author ready
jasnell
approved these changes
Dec 19, 2021
This was referenced Dec 20, 2021
addaleax
approved these changes
Dec 21, 2021
This was referenced Dec 22, 2021
This comment has been minimized.
This comment has been minimized.
This was referenced Dec 25, 2021
This was referenced Jan 1, 2022
26 tasks
19 tasks
RaisinTen
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 461313d |
targos
pushed a commit
that referenced
this pull request
Jan 14, 2022
PR-URL: #41236 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
PR-URL: nodejs#41236 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
PR-URL: #41236 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just trimming some unused
#includelines I spotted, and doing IWYU for STL includes insrc/env.hwhich was transitively getting#include <set>fromsrc/util.h.