-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: make function signature comply with JSDoc comment #41242
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
esm
Issues and PRs related to the ECMAScript Modules implementation.
labels
Dec 19, 2021
aduh95
approved these changes
Dec 19, 2021
Trott
added
request-ci
Add this label to start a Jenkins CI on a PR.
and removed
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Dec 19, 2021
This comment has been minimized.
This comment has been minimized.
jasnell
approved these changes
Dec 19, 2021
BridgeAR
approved these changes
Dec 20, 2021
Trott
added
commit-queue
Add this label to land a pull request using GitHub Actions.
and removed
fast-track
PRs that do not need to wait for 48 hours to land.
labels
Dec 21, 2021
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Dec 21, 2021
Landed in 2bc1d92 |
targos
pushed a commit
that referenced
this pull request
Jan 14, 2022
PR-URL: #41242 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
PR-URL: #41242 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
PR-URL: nodejs#41242 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
PR-URL: #41242 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.