Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: enable zoslib installation on z/OS #41493

Closed
wants to merge 1 commit into from
Closed

build: enable zoslib installation on z/OS #41493

wants to merge 1 commit into from

Conversation

alexcfyung
Copy link
Contributor

Allow node.js to find zoslib headers.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. python PRs and issues that require attention from people who are familiar with Python. labels Jan 12, 2022
richardlau
richardlau approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay. It might be beneficial to others if the commit message had a brief description of what zoslib is and why it is required on z/OS.

@alexcfyung @gabylb
build: enable zoslib installation on z/OS
4da49bc 
zoslib is a C/C++ runtime library and an extended implementation
of the z/OS LE C Runtime Library.

Co-authored-by: Gaby Baghdadi <baghdadi@ca.ibm.com>
@alexcfyung alexcfyung force-pushed the up_setincludedirs_zos branch from 2b6ebac to 4da49bc Compare January 13, 2022 17:10
mhdawson
mhdawson approved these changes Jan 14, 2022
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot mentioned this pull request Jan 15, 2022
Open
26 tasks
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 17, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 17, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41973/

@github-actions github-actions bot mentioned this pull request Jan 18, 2022
Open
16 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42010/

@github-actions github-actions bot mentioned this pull request Jan 19, 2022
Open
13 tasks
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 19, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 19, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42012/

@github-actions github-actions bot mentioned this pull request Jan 20, 2022
Open
17 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42059/

@github-actions github-actions bot mentioned this pull request Jan 21, 2022
Open
19 tasks
mhdawson pushed a commit that referenced this pull request Jan 21, 2022
@alexcfyung @gabylb @mhdawson
build: enable zoslib installation on z/OS
ec1364b 
zoslib is a C/C++ runtime library and an extended implementation
of the z/OS LE C Runtime Library.

PR-URL: #41493
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Co-authored-by: Gaby Baghdadi <baghdadi@ca.ibm.com>
@mhdawson
Copy link
Member

Landed in ec1364b

@mhdawson mhdawson closed this Jan 21, 2022
This was referenced Jan 22, 2022
Open
Open
BethGriggs pushed a commit that referenced this pull request Jan 25, 2022
@alexcfyung @gabylb @BethGriggs
build: enable zoslib installation on z/OS
3335176 
zoslib is a C/C++ runtime library and an extended implementation
of the z/OS LE C Runtime Library.

PR-URL: #41493
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Co-authored-by: Gaby Baghdadi <baghdadi@ca.ibm.com>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@alexcfyung @gabylb @Linkgoron
build: enable zoslib installation on z/OS
3f21cf8 
zoslib is a C/C++ runtime library and an extended implementation
of the z/OS LE C Runtime Library.

PR-URL: nodejs#41493
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Co-authored-by: Gaby Baghdadi <baghdadi@ca.ibm.com>
@ruyadorno ruyadorno mentioned this pull request Feb 8, 2022
Merged
danielleadams pushed a commit that referenced this pull request Feb 28, 2022
@alexcfyung @gabylb @danielleadams
build: enable zoslib installation on z/OS
e2fc1fe 
zoslib is a C/C++ runtime library and an extended implementation
of the z/OS LE C Runtime Library.

PR-URL: #41493
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Co-authored-by: Gaby Baghdadi <baghdadi@ca.ibm.com>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@alexcfyung @gabylb @danielleadams
build: enable zoslib installation on z/OS
ce71283 
zoslib is a C/C++ runtime library and an extended implementation
of the z/OS LE C Runtime Library.

PR-URL: #41493
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Co-authored-by: Gaby Baghdadi <baghdadi@ca.ibm.com>
@danielleadams danielleadams mentioned this pull request Mar 3, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@alexcfyung @gabylb @danielleadams
build: enable zoslib installation on z/OS
261c6d9 
zoslib is a C/C++ runtime library and an extended implementation
of the z/OS LE C Runtime Library.

PR-URL: #41493
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Co-authored-by: Gaby Baghdadi <baghdadi@ca.ibm.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@alexcfyung @gabylb @danielleadams
build: enable zoslib installation on z/OS
5e4fc04 
zoslib is a C/C++ runtime library and an extended implementation
of the z/OS LE C Runtime Library.

PR-URL: #41493
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Co-authored-by: Gaby Baghdadi <baghdadi@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@richardlau richardlau richardlau approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. python PRs and issues that require attention from people who are familiar with Python.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexcfyung @nodejs-github-bot @mhdawson @jasnell @richardlau