-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix typos in esm.md #41499
doc: fix typos in esm.md #41499
Conversation
Review requested:
|
@guybedford By the way, in PACKAGE_RESOLVE method step 11.1, i thought packageURL should be:
Instead of:
Is this another typo? Take code from package.md as an example: // ./node_modules/es-module-package/package.json
{
"exports": {
"./features/*": "./src/features/*.js"
},
"imports": {
"#internal/*": "./src/internal/*.js"
}
} import featureY from 'es-module-package/features/y/y';
// Loads ./node_modules/es-module-package/src/features/y/y.js If concatenated "node_modules/" with packageSpecifier, the packageURL will initially be "./node_modules/es-module-package/src/features/y/y", though according to the loop, it will finally locate packageURL to "./node_modules/es-module-package", but it's a waste of time doing meaningless loop for "src/features/y" path. |
@yu521088 well spotted, yes that is another typo! |
Landed in f458f1b |
PR-URL: nodejs#41499 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Adrian Estrada <edsadr@gmail.com>
PR-URL: #41499 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Adrian Estrada <edsadr@gmail.com>
PR-URL: nodejs#41499 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Adrian Estrada <edsadr@gmail.com>
PR-URL: #41499 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Adrian Estrada <edsadr@gmail.com>
doc: fix typos in esm.md
Update the logic of LOOKUP_PACKAGE_SCOPE method step 2.3:
The pjsonURL should be
instead of
Because packageURL should be
undefined
now.