-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v16.x backport] deps: update ICU to 70.1 #41525
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs: https://github.com/unicode-org/icu/releases/tag/release-70-1 PR-URL: nodejs#40658 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Do not ask to separate the changes in deps/icu-small and in the LICENSE file. Do not ask to remove the whitespace changes. The way commits are landed now doesn't eliminate them anymore. PR-URL: nodejs#40658 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Review requested:
|
nodejs-github-bot
added
meta
Issues and PRs related to the general management of the project.
needs-ci
PRs that need a full CI run.
v16.x
labels
Jan 14, 2022
targos
added
icu
Issues and PRs related to the ICU dependency.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Jan 14, 2022
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jan 14, 2022
RaisinTen
approved these changes
Jan 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
richardlau
approved these changes
Jan 14, 2022
richardlau
added
the
notable-change
PRs with changes that should be highlighted in changelogs.
label
Jan 14, 2022
26 tasks
16 tasks
Landed in 0466400...ab28dc5 |
targos
added a commit
that referenced
this pull request
Jan 18, 2022
Refs: https://github.com/unicode-org/icu/releases/tag/release-70-1 PR-URL: #40658 Backport-PR-URL: #41525 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos
added a commit
that referenced
this pull request
Jan 18, 2022
Do not ask to separate the changes in deps/icu-small and in the LICENSE file. Do not ask to remove the whitespace changes. The way commits are landed now doesn't eliminate them anymore. PR-URL: #40658 Backport-PR-URL: #41525 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
icu
Issues and PRs related to the ICU dependency.
meta
Issues and PRs related to the general management of the project.
needs-ci
PRs that need a full CI run.
notable-change
PRs with changes that should be highlighted in changelogs.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a clean cherry-pick of #40658
Opened as a PR to check CI.