doc: do not reference SSL when discussing SNI #41549
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
Trott
reviewed
Jan 16, 2022
Trott
approved these changes
Jan 16, 2022
Co-authored-by: Rich Trott <rtrott@gmail.com>
tniessen
force-pushed
the
doc-sni-is-tls-not-ssl
branch
from
3bca329
to
d077eb0
Compare
Trott
added
the
author ready
jasnell
approved these changes
Jan 17, 2022
tniessen
added a commit
that referenced
this pull request
Jan 18, 2022
Co-authored-by: Rich Trott <rtrott@gmail.com> PR-URL: #41549 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in c4f5a49, thanks for reviewing. |
thedull
pushed a commit
to thedull/node
that referenced
this pull request
Jan 18, 2022
Co-authored-by: Rich Trott <rtrott@gmail.com> PR-URL: nodejs#41549 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Jan 25, 2022
Co-authored-by: Rich Trott <rtrott@gmail.com> PR-URL: #41549 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
Co-authored-by: Rich Trott <rtrott@gmail.com> PR-URL: nodejs#41549 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 26, 2022
Co-authored-by: Rich Trott <rtrott@gmail.com> PR-URL: #41549 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While some SSL implementation support SNI, it is really a TLS feature. Thus, do not reference the outdated SSL protocol in the context of SNI. (Modern TLS does heavily rely on SNI.)