Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: bump eslint from 8.6.0 to 8.7.0 #41570

Merged
merged 1 commit into from
Jan 18, 2022
Merged

tools: bump eslint from 8.6.0 to 8.7.0 #41570

merged 1 commit into from
Jan 18, 2022

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 17, 2022

No description provided.

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 17, 2022
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jan 17, 2022
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 17, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 17, 2022
@nodejs-github-bot

This comment has been minimized.

Sign in to view
cjihrig
cjihrig approved these changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but doesn't a bot usually handle this now?

@Trott
Copy link
Member Author

Trott commented Jan 17, 2022 •
edited
Loading

LGTM, but doesn't a bot usually handle this now?

Yes, usually, but the ESLint release came out later than they usually do and so the weekly bot run missed it. I supposed I could have dispatched the workflow manually, though.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41965/

@jasnell
Copy link
Member

jasnell commented Jan 17, 2022

Rubber-stamp LGTM

@github-actions github-actions bot mentioned this pull request Jan 18, 2022
Open
16 tasks
@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 18, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 18, 2022
@nodejs-github-bot nodejs-github-bot merged commit 6beee31 into nodejs:master Jan 18, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 6beee31

thedull pushed a commit to thedull/node that referenced this pull request Jan 18, 2022
@Trott @thedull
tools: bump eslint from 8.6.0 to 8.7.0
63484e2 
PR-URL: nodejs#41570
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
This was referenced Jan 19, 2022
Open
Open
BethGriggs pushed a commit that referenced this pull request Jan 25, 2022
@Trott @BethGriggs
tools: bump eslint from 8.6.0 to 8.7.0
127d2fa 
PR-URL: #41570
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@Trott @Linkgoron
tools: bump eslint from 8.6.0 to 8.7.0
e4ec3e5 
PR-URL: nodejs#41570
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Feb 8, 2022
Merged
danielleadams pushed a commit that referenced this pull request Feb 26, 2022
@Trott @danielleadams
tools: bump eslint from 8.6.0 to 8.7.0
3163bd1 
PR-URL: #41570
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@danielleadams danielleadams mentioned this pull request Mar 3, 2022
Merged
@Trott Trott deleted the eslint-8.7.0 branch September 25, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@Mesteery Mesteery Mesteery approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Trott @nodejs-github-bot @jasnell @lpinca @targos @cjihrig @tniessen @Mesteery @VoltrexKeyva