tools: add compile_commands to ignore file #41580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
meta
For developing c++ source files, clangd generates an index file for project via `./configure -C`. We can safely ignore the file from tracking.
yashLadha
force-pushed
the
exclude_compile_commands
branch
from
5da69f6
to
49a74cf
Compare
richardlau
approved these changes
Jan 18, 2022
lpinca
approved these changes
Jan 18, 2022
targos
approved these changes
Jan 24, 2022
targos
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 3ee8c3e |
nodejs-github-bot
added
the
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/41580 ✔ Done loading data for nodejs/node/pull/41580 ----------------------------------- PR info ------------------------------------ Title tools: add compile_commands to ignore file (#41580) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch yashLadha:exclude_compile_commands -> nodejs:master Labels meta Commits 1 - tools: add compile_commands to ignore file Committers 1 - Yash Ladha PR-URL: https://github.com/nodejs/node/pull/41580 Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Michaël Zasso ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41580 Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Michaël Zasso -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 18 Jan 2022 15:49:45 GMT ✔ Approvals: 3 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/41580#pullrequestreview-855654120 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41580#pullrequestreview-855756809 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/41580#pullrequestreview-861036653 ⚠ This PR was merged on Mon, 24 Jan 2022 14:39:31 GMT ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1740412607 |
BethGriggs
pushed a commit
that referenced
this pull request
Jan 25, 2022
For developing c++ source files, clangd generates an index file for project via `./configure -C`. We can safely ignore the file from tracking. PR-URL: #41580 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
For developing c++ source files, clangd generates an index file for project via `./configure -C`. We can safely ignore the file from tracking. PR-URL: nodejs#41580 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 2, 2022
For developing c++ source files, clangd generates an index file for project via `./configure -C`. We can safely ignore the file from tracking. PR-URL: #41580 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 3, 2022
For developing c++ source files, clangd generates an index file for project via `./configure -C`. We can safely ignore the file from tracking. PR-URL: #41580 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 14, 2022
For developing c++ source files, clangd generates an index file for project via `./configure -C`. We can safely ignore the file from tracking. PR-URL: #41580 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing C++ development for static analysis LSP (clangd) is dependant on the
compile_commands.jsonfile which can be generated for nodejs project using./configure -Coption. Though that file is helpful for development and great tooling should not get tracked.Added the
compile_commands.jsonfile to ignore files.