tools: increase maximum line length to 120 characters #41586
Conversation
|
Should this also apply to C++ sources and/or Markdown for consistency? (I'm not saying it's a good idea, but I am curious if the arguments for doing this in JavaScript are really specific to JavaScript.) |
I'd prefer to treat each one separately so that decisions about one don't get complicated by considerations that only apply in one of the other contexts. It might also be good to treat this as an experiment. If anyone is hesitant about increasing the limit, then maybe they'd be comfortable with just trying it for a few months and then deciding if we've had to give a lot of line-length nits or not. But here's my take anyway on C++ and markdown:
|
|
Increasing the c++ limit to 120 works for me. |
Massively favor eliminating line breaks. In general, it seems that the ecosystem has adopted this as a standard, and it's extremely strange for us to be an outlier. |
On a side note, I suspect that most of the ecosystem doesn't need to backport documentation changes to multiple release lines with diverging commit histories, so they are probably less concerned about the increased number of conflicts and the reduced usefulness of git operations such as |
Trott
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
This comment has been minimized.
This comment has been minimized.
Trott
added
request-ci
github-actions
bot
removed
the
request-ci
Trott
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 870044f |
PR-URL: #41586 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
PR-URL: nodejs#41586 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
PR-URL: #41586 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
PR-URL: #41586 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
PR-URL: #41586 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
PR-URL: #41586 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
No description provided.