-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix documentation for MODULE_NOT_FOUND
and ERR_MODULE_NOT_FOUND
#41645
doc: fix documentation for MODULE_NOT_FOUND
and ERR_MODULE_NOT_FOUND
#41645
Conversation
Review requested:
|
Commit Queue failed- Loading data for nodejs/node/pull/41645 ✔ Done loading data for nodejs/node/pull/41645 ----------------------------------- PR info ------------------------------------ Title doc: fix documentation for `MODULE_NOT_FOUND` and `ERR_MODULE_NOT_FOUND` (#41645) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:module-not-found-error-doc -> nodejs:master Labels doc, author ready Commits 1 - doc: fix documentation for `MODULE_NOT_FOUND` and `ERR_MODULE_NOT_FOUND` Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/41645 Fixes: https://github.com/394:11) Fixes: https://github.com/944:10) Fixes: https://github.com/1041:11) Fixes: https://github.com/383:11) Fixes: https://github.com/944:10) Fixes: https://github.com/1041:11) Fixes: https://github.com/394:11) Fixes: https://github.com/944:10) Fixes: https://github.com/1041:11) Fixes: https://github.com/394:11) Fixes: https://github.com/944:10) Fixes: https://github.com/1041:11) Reviewed-By: Guy Bedford Reviewed-By: Geoffrey Booth Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41645 Fixes: https://github.com/394:11) Fixes: https://github.com/944:10) Fixes: https://github.com/1041:11) Fixes: https://github.com/383:11) Fixes: https://github.com/944:10) Fixes: https://github.com/1041:11) Fixes: https://github.com/394:11) Fixes: https://github.com/944:10) Fixes: https://github.com/1041:11) Fixes: https://github.com/394:11) Fixes: https://github.com/944:10) Fixes: https://github.com/1041:11) Reviewed-By: Guy Bedford Reviewed-By: Geoffrey Booth Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 22 Jan 2022 10:41:58 GMT ✔ Approvals: 4 ✔ - Guy Bedford (@guybedford): https://github.com/nodejs/node/pull/41645#pullrequestreview-860194312 ✔ - Geoffrey Booth (@GeoffreyBooth): https://github.com/nodejs/node/pull/41645#pullrequestreview-860227747 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/41645#pullrequestreview-860232926 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41645#pullrequestreview-860235952 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 41645 From https://github.com/nodejs/node * branch refs/pull/41645/merge -> FETCH_HEAD ✔ Fetched commits as c0ef0d5a66e0..9646e1ac4c25 -------------------------------------------------------------------------------- [master aee2e45647] doc: fix documentation for `MODULE_NOT_FOUND` and `ERR_MODULE_NOT_FOUND` Author: Antoine du Hamel Date: Sat Jan 22 11:26:31 2022 +0100 2 files changed, 7 insertions(+), 8 deletions(-) ✔ Patches applied -------------------------------------------------------------------------------- --------------------------------- New Message ---------------------------------- doc: fix documentation for `MODULE_NOT_FOUND` and `ERR_MODULE_NOT_FOUND`https://github.com/nodejs/node/actions/runs/1740375907 |
Commit Queue failed- Loading data for nodejs/node/pull/41645 ✔ Done loading data for nodejs/node/pull/41645 ----------------------------------- PR info ------------------------------------ Title doc: fix documentation for `MODULE_NOT_FOUND` and `ERR_MODULE_NOT_FOUND` (#41645) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:module-not-found-error-doc -> nodejs:master Labels doc, author ready, commit-queue-failed Commits 1 - doc: fix documentation for `MODULE_NOT_FOUND` and `ERR_MODULE_NOT_FOUND` Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/41645 Fixes: https://github.com/394:11) Fixes: https://github.com/944:10) Fixes: https://github.com/1041:11) Fixes: https://github.com/383:11) Fixes: https://github.com/944:10) Fixes: https://github.com/1041:11) Fixes: https://github.com/394:11) Fixes: https://github.com/944:10) Fixes: https://github.com/1041:11) Fixes: https://github.com/394:11) Fixes: https://github.com/944:10) Fixes: https://github.com/1041:11) Reviewed-By: Guy Bedford Reviewed-By: Geoffrey Booth Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41645 Fixes: https://github.com/394:11) Fixes: https://github.com/944:10) Fixes: https://github.com/1041:11) Fixes: https://github.com/383:11) Fixes: https://github.com/944:10) Fixes: https://github.com/1041:11) Fixes: https://github.com/394:11) Fixes: https://github.com/944:10) Fixes: https://github.com/1041:11) Fixes: https://github.com/394:11) Fixes: https://github.com/944:10) Fixes: https://github.com/1041:11) Reviewed-By: Guy Bedford Reviewed-By: Geoffrey Booth Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 22 Jan 2022 10:41:58 GMT ✔ Approvals: 4 ✔ - Guy Bedford (@guybedford): https://github.com/nodejs/node/pull/41645#pullrequestreview-860194312 ✔ - Geoffrey Booth (@GeoffreyBooth): https://github.com/nodejs/node/pull/41645#pullrequestreview-860227747 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/41645#pullrequestreview-860232926 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41645#pullrequestreview-860235952 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 41645 From https://github.com/nodejs/node * branch refs/pull/41645/merge -> FETCH_HEAD ✔ Fetched commits as 3ee8c3e45e5f..9646e1ac4c25 -------------------------------------------------------------------------------- [master 0545239eed] doc: fix documentation for `MODULE_NOT_FOUND` and `ERR_MODULE_NOT_FOUND` Author: Antoine du Hamel Date: Sat Jan 22 11:26:31 2022 +0100 2 files changed, 7 insertions(+), 8 deletions(-) ✔ Patches applied -------------------------------------------------------------------------------- --------------------------------- New Message ---------------------------------- doc: fix documentation for `MODULE_NOT_FOUND` and `ERR_MODULE_NOT_FOUND`https://github.com/nodejs/node/actions/runs/1740412607 |
Landed in 5d88f59 |
PR-URL: nodejs#41645 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #41645 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #41645 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #41645 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #41645 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
ERR_MODULE_NOT_FOUND
was still marked as experimental, probably an oversight from #35781.ERR_MODULE_NOT_FOUND
is thrown wether the target specifier would be an ES module or not (we cannot really know the format of a file that doesn't exist anyway).I've added a note regarding which module loader is involved (sorry @GeoffreyBooth), which is unfortunate but I didn't know how to explain the difference otherwise.
Repro snippets