Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update modules.md wording #41728

Merged
merged 2 commits into from
Jan 30, 2022
Merged

doc: update modules.md wording #41728

merged 2 commits into from
Jan 30, 2022

Conversation

thernstig
Copy link
Contributor

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/modules

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem. labels Jan 28, 2022
aduh95
aduh95 reviewed Jan 28, 2022
View reviewed changes
doc/api/modules.md Outdated Show resolved Hide resolved
@thernstig @aduh95
Apply suggestions from code review
31e96d4 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jan 28, 2022
@Mesteery Mesteery added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 30, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 30, 2022
@nodejs-github-bot nodejs-github-bot merged commit 3dd3a3c into nodejs:master Jan 30, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 3dd3a3c

ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
@thernstig @ruyadorno
doc: update modules.md wording
4889a31 
PR-URL: #41728
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
@ruyadorno ruyadorno mentioned this pull request Feb 8, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@thernstig @danielleadams
doc: update modules.md wording
c761252 
PR-URL: #41728
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
@danielleadams danielleadams mentioned this pull request Mar 3, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@thernstig @danielleadams
doc: update modules.md wording
e0a8252 
PR-URL: #41728
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@thernstig @danielleadams
doc: update modules.md wording
20d9c4a 
PR-URL: #41728
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb left review comments

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@Mesteery Mesteery Mesteery approved these changes

@aduh95 aduh95 aduh95 approved these changes

@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@thernstig @nodejs-github-bot @ljharb @JakobJingleheimer @aduh95 @Mesteery @VoltrexKeyva