Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add missing commas in cluster docs #41865

Merged
merged 1 commit into from
Feb 5, 2022

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Feb 5, 2022

No description provided.

@nodejs-github-bot nodejs-github-bot added cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations. labels Feb 5, 2022
@lpinca lpinca added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2022

Fast-track has been requested by @lpinca. Please 👍 to approve.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 5, 2022
@DerekNonGeneric DerekNonGeneric added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 5, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 5, 2022
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@DerekNonGeneric DerekNonGeneric removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Feb 5, 2022
@DerekNonGeneric
Copy link
Contributor

DerekNonGeneric commented Feb 5, 2022

@Trott, for doc-only changes, it seems a bit of a waste to be running the whole barrage of tests.

Not only does it waste time, but it also unnecessarily wastes electricity and may contribute to climate change.

Can we set up something to detect which type of tests we toggle based on the change reflected by the labels added?

@Trott
Copy link
Member

Trott commented Feb 5, 2022

@Trott, for doc-only changes, it seems a bit of a waste to be running the whole barrage of tests.

Not only does it waste time, but it also unnecessarily wastes electricity and may contribute to climate change.

Can we set up something to detect which type of tests we toggle based on the change reflected by the labels added?

We (usually) don't run Jenkins for doc changes, so we're already running only a fraction of what we do for code changes. We have logic in some of our GitHub Actions workflows to skip in some cases. Efforts to make that more robust would be welcome.

@DerekNonGeneric DerekNonGeneric added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 5, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 5, 2022
@nodejs-github-bot nodejs-github-bot merged commit b8d994a into nodejs:master Feb 5, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in b8d994a

ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
PR-URL: #41865
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
PR-URL: #41865
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
PR-URL: #41865
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams pushed a commit to danielleadams/node that referenced this pull request Mar 4, 2022
PR-URL: nodejs#41865
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams pushed a commit to danielleadams/node that referenced this pull request Mar 4, 2022
PR-URL: nodejs#41865
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams pushed a commit that referenced this pull request Mar 8, 2022
PR-URL: #41865
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
PR-URL: #41865
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants