Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip test-dgram-connect on IBMi #41980

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 15, 2022

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 15, 2022
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 15, 2022
@Trott Trott added fast-track PRs that do not need to wait for 48 hours to land. and removed test Issues and PRs related to the tests. needs-ci PRs that need a full CI run. request-ci Add this label to start a Jenkins CI on a PR. labels Feb 15, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@Trott Trott added needs-ci PRs that need a full CI run. request-ci Add this label to start a Jenkins CI on a PR. test Issues and PRs related to the tests. labels Feb 15, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 15, 2022
@nodejs-github-bot
Copy link
Collaborator

@@ -44,6 +44,7 @@ test-worker-message-port-message-before-close: PASS,FLAKY
test-child-process-fork-net-server: SKIP
test-cli-node-options: SKIP
test-cluster-shared-leak: SKIP
test-dgram-connect: SKIP
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already marked PASS, FLAKY on IBM i

test-dgram-connect: PASS, FLAKY

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Harumph. I thought I checked for that, but clearly, I did not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants