Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove extra <td> #42006

Merged
merged 1 commit into from
Feb 16, 2022
Merged

doc: remove extra <td> #42006

merged 1 commit into from
Feb 16, 2022

Conversation

rayw000
Copy link
Contributor

@rayw000 rayw000 commented Feb 16, 2022 •
edited
Loading

Remove extra <td>

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. readline Issues and PRs related to the built-in readline module. labels Feb 16, 2022
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Feb 16, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 16, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 16, 2022
@nodejs-github-bot nodejs-github-bot merged commit 680f3a5 into nodejs:master Feb 16, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 680f3a5

@rayw000 rayw000 deleted the remove-extra-td branch February 17, 2022 08:10
bengl pushed a commit to bengl/node that referenced this pull request Feb 21, 2022
@rayw000 @bengl
doc: remove extra <td>
a6395bc 
PR-URL: nodejs#42006
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
bengl pushed a commit that referenced this pull request Feb 21, 2022
@rayw000 @bengl
doc: remove extra <td>
16b3d1f 
PR-URL: #42006
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@bengl bengl mentioned this pull request Feb 21, 2022
Merged
bengl pushed a commit that referenced this pull request Feb 21, 2022
@rayw000 @bengl
doc: remove extra <td>
28cd39e 
PR-URL: #42006
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
bengl pushed a commit that referenced this pull request Feb 22, 2022
@rayw000 @bengl
doc: remove extra <td>
c7d590c 
PR-URL: #42006
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@juanarbol
Copy link
Member

This could not be landed cleanly in v16.x' it depends on backporting #41392

@rayw000
Copy link
Contributor Author

rayw000 commented May 28, 2022

This could not be landed cleanly in v16.x' it depends on backporting #41392

Yes. This PR should be labeled as don't-land-to-v16.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mesteery Mesteery Mesteery approved these changes

@marsonya marsonya marsonya approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. readline Issues and PRs related to the built-in readline module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rayw000 @nodejs-github-bot @juanarbol @aduh95 @marsonya @Mesteery