-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
url: more closely align url.parse() with WHATWHG URL #42140
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
semver-major
PRs that contain breaking changes and should be released in the next major version.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Feb 26, 2022
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
url
Issues and PRs related to the legacy built-in url module.
labels
Feb 26, 2022
Trott
added
the
notable-change
PRs with changes that should be highlighted in changelogs.
label
Feb 26, 2022
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Feb 27, 2022
This is not related to this specific change but for non special protocols behavior should be different
Also, there are already some other known issues:
|
In its current state, this is broken enough that I'm going to move it to draft mode to avoid a raft of comments until I get it back into a more workable state. |
There are still lots of ways they are different, but this aligns url.parse() a bit more closely with WHATWHG URL.
Trott
force-pushed
the
url-parse-format-again
branch
from
March 4, 2022 05:38
7b92e94
to
4604a3e
Compare
I don't think this change should land so I'm going to close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs-ci
PRs that need a full CI run.
notable-change
PRs with changes that should be highlighted in changelogs.
semver-major
PRs that contain breaking changes and should be released in the next major version.
url
Issues and PRs related to the legacy built-in url module.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are still lots of ways they are different, but this aligns
url.parse() a bit more closely with WHATWHG URL.
This is a follow-on to #42136 but includes breaking changes.