Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.x backport] tools: enable no-empty ESLint rule #42160

Closed
wants to merge 8 commits into from
Closed

[16.x backport] tools: enable no-empty ESLint rule #42160

wants to merge 8 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 1, 2022

Backport of #41831

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/modules
  • @nodejs/startup

@Trott Trott requested a review from danielleadams March 1, 2022 03:47
@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v16.x labels Mar 1, 2022
@Trott Trott mentioned this pull request Mar 1, 2022
Closed
@Trott
Copy link
Member Author

Trott commented Mar 1, 2022

The lint-md failure is unrelated, but I can add a fix for it here anyway if that's desirable. It would be this:

diff --git a/doc/api/crypto.md b/doc/api/crypto.md
index 83381cffbb..255357108c 100644
--- a/doc/api/crypto.md
+++ b/doc/api/crypto.md
@@ -2532,7 +2532,7 @@ the certificate subject is considered.
 
 If the `'subject'` option is set to `'default'`, the certificate subject is only
 considered if the subject alternative name extension either does not exist or
-does not contain any DNS names. This behavior is consistent with [RFC 2818][]
+does not contain any DNS names. This behavior is consistent with \[RFC 2818]\[]
 ("HTTP Over TLS").

@ljharb
Copy link
Member

ljharb commented Mar 1, 2022

@Trott it seems like that would make it be the literal text [RFC 2818][] instead of a markdown reference link defined by a [RFC 2818]: somewhere else in the document. am i misunderstanding?

@Trott
Copy link
Member Author

Trott commented Mar 1, 2022

@Trott it seems like that would make it be the literal text [RFC 2818][] instead of a markdown reference link defined by a [RFC 2818]: somewhere else in the document. am i misunderstanding?

Hmmm, I did a make format-md and copy/pasted the diff but now that I'm looking at it, yeah, that wouldn't be right. I wonder if there is a remark-ecosysytem update that needs to happen on v16.x-staging or else some other change to our lint rules or code.

@danielleadams
Copy link
Contributor

@Trott @ljharb let me look into this and update the staging branch with the rest of the LTS ready commits. Hopefully, there is a fix since this didn't need to change in v17.x.

@ljharb
Copy link
Member

ljharb commented Mar 1, 2022

It might just be missing the link reference itself; without that present the linter might be tripping up.

@danielleadams
Copy link
Contributor

@ljharb Actually - you're right. I think a commit landed that changed the docs that shouldn't have. The base branch will need to be updated. Sorry for the extra work @Trott, this'll need a rebase after.

@danielleadams
Copy link
Contributor

@Trott The base branch is ready to be rebased, thanks again!

@Trott
benchmark: enable no-empty ESLint rule
bf3bb92 
PR-URL: nodejs#41831
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@Trott
doc: remove empty block from console.timeEnd() example
a24b61a 
PR-URL: nodejs#41831
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@Trott
doc: add comments to empty blocks in worker_threads text
7c0cd14 
PR-URL: nodejs#41831
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@Trott
lib: add comments to empty catch statements
0038697 
PR-URL: nodejs#41831
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@Trott
policy: revise manifest.js to avoid empty blocks
b35692f 
PR-URL: nodejs#41831
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@Trott
stream: remove empty block
d00c97a 
PR-URL: nodejs#41831
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@Trott
Copy link
Member Author

Trott commented Mar 2, 2022

@Trott The base branch is ready to be rebased, thanks again!

OK, rebased.

@Trott
Copy link
Member Author

Trott commented Mar 2, 2022

(Fixing the lint errors...)

@Trott
test: enable no-empty ESLint rule
48f5a12 
PR-URL: nodejs#41831
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@Trott
tools: enable no-empty ESLint rule
01c3818 
Refs: https://eslint.org/docs/rules/no-empty

PR-URL: nodejs#41831
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@Trott
Copy link
Member Author

Trott commented Mar 2, 2022

OK, now it should be ready.

danielleadams pushed a commit to danielleadams/node that referenced this pull request Mar 4, 2022
@Trott @danielleadams
policy: revise manifest.js to avoid empty blocks
e06462b 
PR-URL: nodejs#41831
Backport-PR-URL: nodejs#42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit to danielleadams/node that referenced this pull request Mar 4, 2022
@Trott @danielleadams
stream: remove empty block
b0366f1 
PR-URL: nodejs#41831
Backport-PR-URL: nodejs#42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit to danielleadams/node that referenced this pull request Mar 4, 2022
@Trott @danielleadams
test: enable no-empty ESLint rule
19f2168 
PR-URL: nodejs#41831
Backport-PR-URL: nodejs#42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit to danielleadams/node that referenced this pull request Mar 4, 2022
@Trott @danielleadams
tools: enable no-empty ESLint rule
475be6c 
Refs: https://eslint.org/docs/rules/no-empty

PR-URL: nodejs#41831
Backport-PR-URL: nodejs#42160
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit to danielleadams/node that referenced this pull request Mar 4, 2022
@Trott @danielleadams
benchmark: enable no-empty ESLint rule
1acb5cd 
PR-URL: nodejs#41831
Backport-PR-URL: nodejs#42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit to danielleadams/node that referenced this pull request Mar 4, 2022
@Trott @danielleadams
doc: remove empty block from console.timeEnd() example
b302ea1 
PR-URL: nodejs#41831
Backport-PR-URL: nodejs#42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit to danielleadams/node that referenced this pull request Mar 4, 2022
@Trott @danielleadams
doc: add comments to empty blocks in worker_threads text
1639379 
PR-URL: nodejs#41831
Backport-PR-URL: nodejs#42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit to danielleadams/node that referenced this pull request Mar 4, 2022
@Trott @danielleadams
lib: add comments to empty catch statements
7bf4fbc 
PR-URL: nodejs#41831
Backport-PR-URL: nodejs#42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit to danielleadams/node that referenced this pull request Mar 4, 2022
@Trott @danielleadams
policy: revise manifest.js to avoid empty blocks
4a75e86 
PR-URL: nodejs#41831
Backport-PR-URL: nodejs#42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit to danielleadams/node that referenced this pull request Mar 4, 2022
@Trott @danielleadams
stream: remove empty block
671dec2 
PR-URL: nodejs#41831
Backport-PR-URL: nodejs#42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit to danielleadams/node that referenced this pull request Mar 4, 2022
@Trott @danielleadams
test: enable no-empty ESLint rule
783f8ef 
PR-URL: nodejs#41831
Backport-PR-URL: nodejs#42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit to danielleadams/node that referenced this pull request Mar 4, 2022
@Trott @danielleadams
tools: enable no-empty ESLint rule
ac8537d 
Refs: https://eslint.org/docs/rules/no-empty

PR-URL: nodejs#41831
Backport-PR-URL: nodejs#42160
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 8, 2022
@Trott @danielleadams
benchmark: enable no-empty ESLint rule
26205b4 
PR-URL: #41831
Backport-PR-URL: #42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 8, 2022
@Trott @danielleadams
doc: remove empty block from console.timeEnd() example
7869f85 
PR-URL: #41831
Backport-PR-URL: #42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 8, 2022
@Trott @danielleadams
doc: add comments to empty blocks in worker_threads text
17860eb 
PR-URL: #41831
Backport-PR-URL: #42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 8, 2022
@Trott @danielleadams
lib: add comments to empty catch statements
2ba99b5 
PR-URL: #41831
Backport-PR-URL: #42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 8, 2022
@Trott @danielleadams
policy: revise manifest.js to avoid empty blocks
1f37a39 
PR-URL: #41831
Backport-PR-URL: #42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 8, 2022
@Trott @danielleadams
stream: remove empty block
96cfaba 
PR-URL: #41831
Backport-PR-URL: #42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 8, 2022
@Trott @danielleadams
test: enable no-empty ESLint rule
c78168f 
PR-URL: #41831
Backport-PR-URL: #42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 8, 2022
@Trott @danielleadams
tools: enable no-empty ESLint rule
1e47815 
Refs: https://eslint.org/docs/rules/no-empty

PR-URL: #41831
Backport-PR-URL: #42160
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This was referenced Mar 10, 2022
Open
Open
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@Trott @danielleadams
benchmark: enable no-empty ESLint rule
c4a296f 
PR-URL: #41831
Backport-PR-URL: #42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@Trott @danielleadams
doc: remove empty block from console.timeEnd() example
125ed0c 
PR-URL: #41831
Backport-PR-URL: #42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@Trott @danielleadams
doc: add comments to empty blocks in worker_threads text
330c1bc 
PR-URL: #41831
Backport-PR-URL: #42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@Trott @danielleadams
lib: add comments to empty catch statements
acd8768 
PR-URL: #41831
Backport-PR-URL: #42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@Trott @danielleadams
policy: revise manifest.js to avoid empty blocks
08b3bd2 
PR-URL: #41831
Backport-PR-URL: #42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@Trott @danielleadams
stream: remove empty block
aebd82e 
PR-URL: #41831
Backport-PR-URL: #42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@Trott @danielleadams
test: enable no-empty ESLint rule
c8e59cb 
PR-URL: #41831
Backport-PR-URL: #42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@Trott @danielleadams
tools: enable no-empty ESLint rule
788e77c 
Refs: https://eslint.org/docs/rules/no-empty

PR-URL: #41831
Backport-PR-URL: #42160
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@danielleadams danielleadams danielleadams approved these changes

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @nodejs-github-bot @ljharb @danielleadams @GeoffreyBooth @RaisinTen