Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v16.x backport] net: add new options to net.Socket and net.Server #42298

Closed
wants to merge 2 commits into from
Closed

[v16.x backport] net: add new options to net.Socket and net.Server #42298

wants to merge 2 commits into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Mar 11, 2022

Backport of #41310 and #42268.

@aduh95 aduh95 added the semver-minor PRs that contain new features and should be released in the next minor version. label Mar 11, 2022
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem. v16.x labels Mar 11, 2022
mcollina
mcollina approved these changes Mar 11, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielleadams
Copy link
Contributor

@aduh95 can you rebase this?

ShogunPanda and others added 2 commits April 10, 2022 13:31
@ShogunPanda @aduh95
net: add new options to net.Socket and net.Server
ed2073c 
PR-URL: nodejs#41310
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95
doc: fix version history for net.Socket and net.Server
ce4a7e1 
Refs: nodejs#41310

PR-URL: nodejs#42268
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43425/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43429/

@danielleadams
Copy link
Contributor

Landed in 85e3624...f8819e8

danielleadams pushed a commit that referenced this pull request Apr 11, 2022
@ShogunPanda @danielleadams
net: add new options to net.Socket and net.Server
b3afb20 
PR-URL: #41310
Backport-PR-URL: #42298
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Apr 11, 2022
@aduh95 @danielleadams
doc: fix version history for net.Socket and net.Server
f8819e8 
Refs: #41310

PR-URL: #42268
Backport-PR-URL: #42298
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@aduh95 aduh95 deleted the net-socket-options-v16.x branch April 11, 2022 12:34
This was referenced Apr 12, 2022
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@danielleadams danielleadams danielleadams approved these changes

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aduh95 @nodejs-github-bot @danielleadams @mcollina @ShogunPanda