test: improve code coverage for inspector connection errors #42310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cola119
force-pushed
the
debugger-error-test-improve
branch
from
7fe0f4c
to
6248cbc
Compare
cola119
changed the title
nodejs-github-bot
added
needs-ci
cola119
changed the title
cola119
force-pushed
the
debugger-error-test-improve
branch
from
6248cbc
to
31f19cc
Compare
cola119
force-pushed
the
debugger-error-test-improve
branch
from
31f19cc
to
ba42c4c
Compare
RaisinTen
approved these changes
Mar 13, 2022
This comment was marked as outdated.
This comment was marked as outdated.
lpinca
approved these changes
Mar 13, 2022
28 tasks
jasnell
approved these changes
Mar 14, 2022
20 tasks
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Mar 16, 2022
RaisinTen
added
the
author ready
github-actions
bot
removed
the
request-ci
This was referenced May 20, 2022
This was referenced May 23, 2022
|
Landed in ee91acb |
19 tasks
bengl
pushed a commit
that referenced
this pull request
May 30, 2022
PR-URL: #42310 Refs: https://coverage.nodejs.org/coverage-457567f72ca73ef0/lib/inspector.js.html#L74 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Jun 27, 2022
PR-URL: #42310 Refs: https://coverage.nodejs.org/coverage-457567f72ca73ef0/lib/inspector.js.html#L74 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
PR-URL: #42310 Refs: https://coverage.nodejs.org/coverage-457567f72ca73ef0/lib/inspector.js.html#L74 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #42310 Refs: https://coverage.nodejs.org/coverage-457567f72ca73ef0/lib/inspector.js.html#L74 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#42310 Refs: https://coverage.nodejs.org/coverage-457567f72ca73ef0/lib/inspector.js.html#L74 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added tests for error branches in
connectToMainThread. This is a small change but improves code coverage a bit.Refs: lib/inspector.js.html#L74 and lib/inspector.js.html#L76