-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update instructions for openssl updates #42353
Conversation
Update to reflect additional PRs needed as some branches now use OpenSSL 3.x Signed-off-by: Michael Dawson <mdawson@devrus.com>
Review requested:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also optionally rename the "OpenSSL 3.0.0" heading later on to "OpenSSL 3.0.x" and maybe update to use a non-alpha example.
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
```console | ||
$ make -C deps/openssl/config | ||
$ git add deps/openssl/config/archs | ||
$ git add deps/openssl/openssl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@richard this matches what is in the commit comments below and looks like what we have done. It is probably also related to #42081 as git add deps/openssl/openssl
adds all of the headers under openssl/openssl/include
versus the selective ones that were added for OpenSSL 1.1.1.
I don't think we want to change right now as we get releases out, but worth looking to see if possibly we can revert to adding just those three, find out why more were needed and possibly ask @danbev when he gets back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I take that back since I guess the the examples were only showing the git adds
that were necessary for a particular commit as opposed to what needs to be done in general. Therefore, it likely is not related to #42081 after all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW AFAICT the big difference between OpenSSL 1.1.1 and 3.0.x in Node.js is the deps/openssl/config/archs
-- there's many more files in OpenSSL 3.0.x under there (see description in #42081) and a preliminary glance suggested a lot of duplication between the archs.
done |
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Added https://github.com/nodejs/node/labels/backport-requested-v16%2Ex as we probably want to address #42353 (comment). |
Commit Queue failed- Loading data for nodejs/node/pull/42353 ✔ Done loading data for nodejs/node/pull/42353 ----------------------------------- PR info ------------------------------------ Title doc: update instructions for openssl updates (#42353) Author Michael Dawson (@mhdawson) Branch mhdawson:update-openssl-instructions -> nodejs:master Labels doc, backport-requested-v16.x, commit-queue-squash Commits 9 - doc: update instructions for openssl updates - Update doc/contributing/maintaining-openssl.md - Update doc/contributing/maintaining-openssl.md - Update doc/contributing/maintaining-openssl.md - squash address comments - squash:fixup - Update doc/contributing/maintaining-openssl.md - Update doc/contributing/maintaining-openssl.md - Update doc/contributing/maintaining-openssl.md Committers 2 - Michael Dawson - GitHub PR-URL: https://github.com/nodejs/node/pull/42353 Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Antoine du Hamel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/42353 Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Antoine du Hamel -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 15 Mar 2022 21:24:08 GMT ✔ Approvals: 3 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/42353#pullrequestreview-910851918 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/42353#pullrequestreview-912180819 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/42353#pullrequestreview-912906182 ✖ This PR needs to wait 11 more hours to land ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1997890318 |
Update to reflect additional PRs needed as some branches now use OpenSSL 3.x Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #42353 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Landed in cc64c93 |
Update to reflect additional PRs needed as some branches now use OpenSSL 3.x Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #42353 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Update to reflect additional PRs needed as some branches now use OpenSSL 3.x Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs#42353 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Update to reflect additional PRs needed as some
branches now use OpenSSL 3.x
Signed-off-by: Michael Dawson mdawson@devrus.com