test: improve internal/worker/io.js coverage #42387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
RaisinTen
approved these changes
Mar 21, 2022
Trott
approved these changes
Mar 22, 2022
jasnell
approved these changes
Mar 25, 2022
marsonya
added
worker
marsonya
approved these changes
Apr 2, 2022
github-actions
bot
removed
the
request-ci
This was referenced Apr 3, 2022
github-actions
bot
removed
the
request-ci
watilde
approved these changes
Apr 8, 2022
This was referenced Apr 9, 2022
github-actions
bot
removed
the
request-ci
This was referenced May 14, 2022
This was referenced Jul 24, 2023
This was referenced Jul 30, 2023
debadree25
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/42387 ✔ Done loading data for nodejs/node/pull/42387 ----------------------------------- PR info ------------------------------------ Title test: improve internal/worker/io.js coverage (#42387) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch kuriyosh:test-bc-ref -> nodejs:main Labels test, author ready, worker, needs-ci Commits 1 - test: improve internal/worker/io.js coverage Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/42387 Refs: https://coverage.nodejs.org/coverage-6d3920d579a3dc3a/lib/internal/worker/io.js.html#L485 Reviewed-By: Darshan Sen Reviewed-By: Rich Trott Reviewed-By: James M Snell Reviewed-By: Akhil Marsonya Reviewed-By: Daijiro Wachi Reviewed-By: Luigi Pinca Reviewed-By: Debadree Chatterjee Reviewed-By: Michael Dawson ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/42387 Refs: https://coverage.nodejs.org/coverage-6d3920d579a3dc3a/lib/internal/worker/io.js.html#L485 Reviewed-By: Darshan Sen Reviewed-By: Rich Trott Reviewed-By: James M Snell Reviewed-By: Akhil Marsonya Reviewed-By: Daijiro Wachi Reviewed-By: Luigi Pinca Reviewed-By: Debadree Chatterjee Reviewed-By: Michael Dawson -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - test: improve internal/worker/io.js coverage ℹ This PR was created on Fri, 18 Mar 2022 04:50:02 GMT ✔ Approvals: 8 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/42387#pullrequestreview-915843402 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/42387#pullrequestreview-916593214 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/42387#pullrequestreview-922217924 ✔ - Akhil Marsonya (@marsonya): https://github.com/nodejs/node/pull/42387#pullrequestreview-929588367 ✔ - Daijiro Wachi (@watilde): https://github.com/nodejs/node/pull/42387#pullrequestreview-935904833 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/42387#pullrequestreview-1293927250 ✔ - Debadree Chatterjee (@debadree25): https://github.com/nodejs/node/pull/42387#pullrequestreview-1405859339 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/42387#pullrequestreview-1413851278 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-07-29T12:49:45Z: https://ci.nodejs.org/job/node-test-pull-request/52975/ - Querying data for job/node-test-pull-request/52975/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/5713219443 |
debadree25
approved these changes
Jul 31, 2023
debadree25
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 1dcfc65 |
pluris
pushed a commit
to pluris/node
that referenced
this pull request
Aug 6, 2023
PR-URL: nodejs#42387 Refs: https://coverage.nodejs.org/coverage-6d3920d579a3dc3a/lib/internal/worker/io.js.html#L485 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
pluris
pushed a commit
to pluris/node
that referenced
this pull request
Aug 7, 2023
PR-URL: nodejs#42387 Refs: https://coverage.nodejs.org/coverage-6d3920d579a3dc3a/lib/internal/worker/io.js.html#L485 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#42387 Refs: https://coverage.nodejs.org/coverage-6d3920d579a3dc3a/lib/internal/worker/io.js.html#L485 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#42387 Refs: https://coverage.nodejs.org/coverage-6d3920d579a3dc3a/lib/internal/worker/io.js.html#L485 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
UlisesGascon
pushed a commit
to UlisesGascon/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#42387 Refs: https://coverage.nodejs.org/coverage-6d3920d579a3dc3a/lib/internal/worker/io.js.html#L485 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 15, 2023
PR-URL: #42387 Refs: https://coverage.nodejs.org/coverage-6d3920d579a3dc3a/lib/internal/worker/io.js.html#L485 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Merged
RafaelGSS
pushed a commit
to RafaelGSS/node
that referenced
this pull request
Aug 15, 2023
PR-URL: nodejs#42387 Refs: https://coverage.nodejs.org/coverage-6d3920d579a3dc3a/lib/internal/worker/io.js.html#L485 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 17, 2023
PR-URL: #42387 Refs: https://coverage.nodejs.org/coverage-6d3920d579a3dc3a/lib/internal/worker/io.js.html#L485 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves a test coverage in
internal/worker/io.jsref: https://coverage.nodejs.org/coverage-6d3920d579a3dc3a/lib/internal/worker/io.js.html#L485
This PR adds a test that validates the
BroadcastChannel.ref()method works correctly.