Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer: remove mustMatch from Buffer.bytelength() #42482

Closed
wants to merge 1 commit into from
Closed

buffer: remove mustMatch from Buffer.bytelength() #42482

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 26, 2022

Buffer.bytelength() has an undocumented third parameterm mustMatch.
Remove it.

Closes: #38536

@Trott
buffer: remove mustMatch from Buffer.bytelength()
9259c7e 
Buffer.bytelength() has an undocumented third parameterm `mustMatch`.
Remove it.

Closes: nodejs#38536
@Trott Trott added the semver-major PRs that contain breaking changes and should be released in the next major version. label Mar 26, 2022
@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. needs-ci PRs that need a full CI run. labels Mar 26, 2022
@Trott
Copy link
Member Author

Trott commented Mar 26, 2022

Duplicative of #38545

@Trott Trott closed this Mar 26, 2022
@Trott Trott deleted the mustMatch branch March 26, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Buffer.byteLength's implementation is not consistent with the documentation
2 participants
@Trott @nodejs-github-bot