Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

child_process: add env contents types in JSDoc #42494

Merged
merged 1 commit into from
Mar 30, 2022
Merged

child_process: add env contents types in JSDoc #42494

merged 1 commit into from
Mar 30, 2022

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 27, 2022

Use JSDoc to indicate that the env object keys and values must be
strings.

Refs: #42489 (comment)

@Trott Trott requested a review from aduh95 March 27, 2022 15:40
@nodejs-github-bot nodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. needs-ci PRs that need a full CI run. labels Mar 27, 2022
Mesteery
Mesteery reviewed Mar 27, 2022
View reviewed changes
lib/child_process.js Outdated Show resolved Hide resolved
@Trott
child_process: add env contents types in JSDoc
69ae2cc 
Use JSDoc to indicate that the `env` object keys and values must be
strings.

Refs: nodejs#42489 (comment)
@Trott Trott added commit-queue Add this label to land a pull request using GitHub Actions. request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 29, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 29, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43229/

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 30, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 30, 2022
@nodejs-github-bot nodejs-github-bot merged commit f8ca5df into nodejs:master Mar 30, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in f8ca5df

@Trott Trott deleted the env-jsdoc branch March 30, 2022 14:04
@github-actions github-actions bot mentioned this pull request Apr 4, 2022
Open
9 tasks
juanarbol pushed a commit that referenced this pull request Apr 4, 2022
@Trott @juanarbol
child_process: add env contents types in JSDoc
47a0b97 
Use JSDoc to indicate that the `env` object keys and values must be
strings.

Refs: #42489 (comment)

PR-URL: #42494
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
juanarbol pushed a commit to juanarbol/node that referenced this pull request Apr 5, 2022
@Trott @juanarbol
child_process: add env contents types in JSDoc
7105f8b 
Use JSDoc to indicate that the `env` object keys and values must be
strings.

Refs: nodejs#42489 (comment)

PR-URL: nodejs#42494
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This was referenced Apr 5, 2022
Closed
Merged
juanarbol pushed a commit that referenced this pull request Apr 6, 2022
@Trott @juanarbol
child_process: add env contents types in JSDoc
9a54acb 
Use JSDoc to indicate that the `env` object keys and values must be
strings.

Refs: #42489 (comment)

PR-URL: #42494
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
@Trott @xtx1130
child_process: add env contents types in JSDoc
a925f31 
Use JSDoc to indicate that the `env` object keys and values must be
strings.

Refs: nodejs#42489 (comment)

PR-URL: nodejs#42494
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
juanarbol pushed a commit that referenced this pull request May 31, 2022
@Trott @juanarbol
child_process: add env contents types in JSDoc
687b853 
Use JSDoc to indicate that the `env` object keys and values must be
strings.

Refs: #42489 (comment)

PR-URL: #42494
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@juanarbol juanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@Trott @danielleadams
child_process: add env contents types in JSDoc
7821df2 
Use JSDoc to indicate that the `env` object keys and values must be
strings.

Refs: #42489 (comment)

PR-URL: #42494
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Jul 11, 2022
@Trott @targos
child_process: add env contents types in JSDoc
976636f 
Use JSDoc to indicate that the `env` object keys and values must be
strings.

Refs: #42489 (comment)

PR-URL: #42494
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Jul 11, 2022
@Trott @targos
child_process: add env contents types in JSDoc
52a96c7 
Use JSDoc to indicate that the `env` object keys and values must be
strings.

Refs: #42489 (comment)

PR-URL: #42494
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@Trott @targos
child_process: add env contents types in JSDoc
72400b7 
Use JSDoc to indicate that the `env` object keys and values must be
strings.

Refs: #42489 (comment)

PR-URL: #42494
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@Trott @guangwong
child_process: add env contents types in JSDoc
2914878 
Use JSDoc to indicate that the `env` object keys and values must be
strings.

Refs: nodejs/node#42489 (comment)

PR-URL: nodejs/node#42494
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mesteery Mesteery Mesteery left review comments

@aduh95 aduh95 aduh95 approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
child_process Issues and PRs related to the child_process subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @nodejs-github-bot @benjamingr @aduh95 @Mesteery