Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix typo in common/wpt.js #42567

Merged
merged 1 commit into from
Apr 2, 2022
Merged

Conversation

eltociear
Copy link
Contributor

thw -> the

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 1, 2022
@marsonya marsonya removed the needs-ci PRs that need a full CI run. label Apr 1, 2022
@marsonya marsonya added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2022

Fast-track has been requested by @marsonya. Please 👍 to approve.

@marsonya marsonya added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 1, 2022
@marsonya marsonya added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 1, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 1, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/42567
✔  Done loading data for nodejs/node/pull/42567
----------------------------------- PR info ------------------------------------
Title      test: fix typo in common/wpt.js (#42567)
Author     Ikko Ashimine  (@eltociear)
Branch     eltociear:patch-8 -> nodejs:master
Labels     test, fast-track, author ready
Commits    1
 - test: fix typo in common/wpt.js
Committers 1
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/42567
Reviewed-By: Zeyu Yang 
Reviewed-By: Colin Ihrig 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Akhil Marsonya 
Reviewed-By: Luigi Pinca 
Reviewed-By: Tobias Nießen 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/42567
Reviewed-By: Zeyu Yang 
Reviewed-By: Colin Ihrig 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Akhil Marsonya 
Reviewed-By: Luigi Pinca 
Reviewed-By: Tobias Nießen 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 01 Apr 2022 14:03:18 GMT
   ✔  Approvals: 6
   ✔  - Zeyu Yang (@himself65): https://github.com/nodejs/node/pull/42567#pullrequestreview-929000674
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/42567#pullrequestreview-929027796
   ✔  - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/42567#pullrequestreview-929078664
   ✔  - Akhil Marsonya (@marsonya): https://github.com/nodejs/node/pull/42567#pullrequestreview-929149813
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/42567#pullrequestreview-929156607
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/42567#pullrequestreview-929305497
   ℹ  This PR is being fast-tracked
   ✔  Last GitHub CI successful
   ✖  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/2079678250

@Trott Trott added request-ci Add this label to start a Jenkins CI on a PR. commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Apr 1, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 1, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 2, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/42567
✔  Done loading data for nodejs/node/pull/42567
----------------------------------- PR info ------------------------------------
Title      test: fix typo in common/wpt.js (#42567)
Author     Ikko Ashimine  (@eltociear)
Branch     eltociear:patch-8 -> nodejs:master
Labels     test, fast-track, author ready
Commits    1
 - test: fix typo in common/wpt.js
Committers 1
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/42567
Reviewed-By: Zeyu Yang 
Reviewed-By: Colin Ihrig 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Akhil Marsonya 
Reviewed-By: Luigi Pinca 
Reviewed-By: Tobias Nießen 
Reviewed-By: Rich Trott 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/42567
Reviewed-By: Zeyu Yang 
Reviewed-By: Colin Ihrig 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Akhil Marsonya 
Reviewed-By: Luigi Pinca 
Reviewed-By: Tobias Nießen 
Reviewed-By: Rich Trott 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 01 Apr 2022 14:03:18 GMT
   ✔  Approvals: 7
   ✔  - Zeyu Yang (@himself65): https://github.com/nodejs/node/pull/42567#pullrequestreview-929000674
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/42567#pullrequestreview-929027796
   ✔  - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/42567#pullrequestreview-929078664
   ✔  - Akhil Marsonya (@marsonya): https://github.com/nodejs/node/pull/42567#pullrequestreview-929149813
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/42567#pullrequestreview-929156607
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/42567#pullrequestreview-929305497
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/42567#pullrequestreview-929491056
   ℹ  This PR is being fast-tracked
   ✔  Last GitHub CI successful
   ✖  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/2080321128

@nodejs-github-bot nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Apr 2, 2022
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

@marsonya marsonya added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Apr 2, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 2, 2022
@nodejs-github-bot nodejs-github-bot merged commit 127da0f into nodejs:master Apr 2, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 127da0f

juanarbol pushed a commit to juanarbol/node that referenced this pull request Apr 5, 2022
thw -> the

PR-URL: nodejs#42567
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Apr 5, 2022
juanarbol pushed a commit that referenced this pull request Apr 6, 2022
thw -> the

PR-URL: #42567
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
thw -> the

PR-URL: nodejs#42567
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
juanarbol pushed a commit that referenced this pull request May 31, 2022
thw -> the

PR-URL: #42567
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
thw -> the

PR-URL: #42567
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Jul 11, 2022
thw -> the

PR-URL: #42567
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
thw -> the

PR-URL: #42567
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
thw -> the

PR-URL: nodejs/node#42567
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants