src,crypto: remove uses of AllocatedBuffer from crypto_tls.cc
#42589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs: nodejs#39941 Signed-off-by: Darshan Sen <raisinten@gmail.com>
|
Review requested:
|
nodejs-github-bot
added
c++
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
approved these changes
Apr 3, 2022
RaisinTen
added
the
author ready
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
13 tasks
This was referenced Apr 6, 2022
RaisinTen
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/42589 ✔ Done loading data for nodejs/node/pull/42589 ----------------------------------- PR info ------------------------------------ Title src,crypto: remove uses of `AllocatedBuffer` from `crypto_tls.cc` (#42589) Author Darshan Sen (@RaisinTen) Branch RaisinTen:src,crypto/remove-uses-of-AllocatedBuffer-from-crypto_tls.cc -> nodejs:master Labels crypto, c++, author ready, needs-ci Commits 1 - src,crypto: remove uses of AllocatedBuffer from crypto_tls.cc Committers 1 - Darshan Sen PR-URL: https://github.com/nodejs/node/pull/42589 Refs: https://github.com/nodejs/node/pull/39941 Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/42589 Refs: https://github.com/nodejs/node/pull/39941 Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 03 Apr 2022 14:23:51 GMT ✔ Approvals: 1 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/42589#pullrequestreview-929688191 ✖ This PR needs to wait 0 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-04-05T01:08:37Z: https://ci.nodejs.org/job/node-test-pull-request/43332/ - Querying data for job/node-test-pull-request/43332/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2144158229 |
RaisinTen
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 0c57a37 |
RaisinTen
deleted the
src,crypto/remove-uses-of-AllocatedBuffer-from-crypto_tls.cc
branch
xtx1130
pushed a commit
to xtx1130/node
that referenced
this pull request
Apr 25, 2022
Refs: nodejs#39941 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs#42589 Reviewed-By: James M Snell <jasnell@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
Refs: nodejs/node#39941 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs/node#42589 Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #39941
Signed-off-by: Darshan Sen raisinten@gmail.com