Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: change AES-GCM IV recommendation in WebCrypto #42611

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Apr 5, 2022

Properly constructing IVs is one of the most important factors when using AES-GCM. Contrary to what the documentation says, random values are not ideal, however, sufficiently long random byte sequences are acceptable when the application cannot deterministically construct unique IVs.

Instead of referring to "the AES-GCM specification", explicitly refer to Section 8 of NIST SP 800-38D.

@tniessen tniessen requested a review from jasnell April 5, 2022 00:13
@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Apr 5, 2022
@tniessen tniessen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 5, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 12, 2022
@nodejs-github-bot nodejs-github-bot merged commit 6706be1 into nodejs:master Apr 12, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 6706be1

xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
PR-URL: nodejs#42611
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
juanarbol pushed a commit that referenced this pull request May 31, 2022
PR-URL: #42611
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
PR-URL: #42611
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
targos pushed a commit that referenced this pull request Jul 11, 2022
PR-URL: #42611
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #42611
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#42611
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants