Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add configure option --v8-enable-short-builtin-calls #42688

Conversation

qdaoming
Copy link
Contributor

Add configure option --v8-enable-short-builtin-calls
and enable it by default on x86_64 platform.

Add configure option --v8-enable-short-builtin-calls
and enable it by default on x86_64 platform.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Apr 11, 2022
@qdaoming
Copy link
Contributor Author

qdaoming commented Apr 11, 2022

This pull request is refactored from: #42109, which met "Commit Queue failed" error.

@gengjiawen gengjiawen added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 11, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 11, 2022
@nodejs-github-bot
Copy link
Collaborator

@gengjiawen
Copy link
Member

Since @Trott rebased your original PR, I will close this one. My thought is to keep the original PR for node-core-utils team to fix the empty issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants