Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update clang-format 1.6.0 to 1.7.0 #42724

Merged
merged 1 commit into from
Apr 14, 2022
Merged

tools: update clang-format 1.6.0 to 1.7.0 #42724

merged 1 commit into from
Apr 14, 2022

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 13, 2022

This resolves npm audit warnings when running make format-cpp-build.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Apr 13, 2022
@Trott Trott mentioned this pull request Apr 13, 2022
Closed
@Trott Trott requested a review from RaisinTen April 13, 2022 16:27
@Trott
tools: update clang-format 1.6.0 to 1.7.0
c5d3f8d 
This resolves `npm audit` warnings when running `make format-cpp-build`.
@Trott Trott changed the title chore: update clang-format 1.6.0 to 1.7.0 tools: update clang-format 1.6.0 to 1.7.0 Apr 13, 2022
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 13, 2022
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 14, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 14, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 14, 2022
@nodejs-github-bot nodejs-github-bot merged commit f076c36 into nodejs:master Apr 14, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in f076c36

@XadillaX XadillaX mentioned this pull request Apr 14, 2022
Closed
@Trott Trott deleted the clang-format-1.7.0 branch April 14, 2022 05:54
@BethGriggs BethGriggs mentioned this pull request Apr 14, 2022
Merged
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
@Trott @xtx1130
tools: update clang-format 1.6.0 to 1.7.0
f0af5a0 
This resolves `npm audit` warnings when running `make format-cpp-build`.

PR-URL: nodejs#42724
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
juanarbol pushed a commit that referenced this pull request May 31, 2022
@Trott @juanarbol
tools: update clang-format 1.6.0 to 1.7.0
a7a59ac 
This resolves `npm audit` warnings when running `make format-cpp-build`.

PR-URL: #42724
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@juanarbol juanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@Trott @danielleadams
tools: update clang-format 1.6.0 to 1.7.0
ed273fd 
This resolves `npm audit` warnings when running `make format-cpp-build`.

PR-URL: #42724
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit that referenced this pull request Jul 11, 2022
@Trott @targos
tools: update clang-format 1.6.0 to 1.7.0
2e6498a 
This resolves `npm audit` warnings when running `make format-cpp-build`.

PR-URL: #42724
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit that referenced this pull request Jul 31, 2022
@Trott @targos
tools: update clang-format 1.6.0 to 1.7.0
3370ef9 
This resolves `npm audit` warnings when running `make format-cpp-build`.

PR-URL: #42724
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@Trott @guangwong
tools: update clang-format 1.6.0 to 1.7.0
cd33704 
This resolves `npm audit` warnings when running `make format-cpp-build`.

PR-URL: nodejs/node#42724
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@tniessen tniessen tniessen approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @nodejs-github-bot @lpinca @tniessen @RaisinTen @VoltrexKeyva