-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: clarify core modules that can be loaded without a prefix #42753
doc: clarify core modules that can be loaded without a prefix #42753
Conversation
Review requested:
|
Co-authored-by: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Commit Queue failed- Loading data for nodejs/node/pull/42753 ✔ Done loading data for nodejs/node/pull/42753 ----------------------------------- PR info ------------------------------------ Title doc: clarify core modules that can be loaded without a prefix (#42753) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:update-docs-regarding-node-prefix -> nodejs:master Labels doc, module, author ready Commits 2 - doc: clarify core modules that can be loaded without a prefix - Update doc/api/modules.md Committers 2 - Antoine du Hamel - GitHub PR-URL: https://github.com/nodejs/node/pull/42753 Refs: https://github.com/nodejs/node/pull/42325 Reviewed-By: Geoffrey Booth Reviewed-By: Jacob Smith Reviewed-By: Mestery ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/42753 Refs: https://github.com/nodejs/node/pull/42325 Reviewed-By: Geoffrey Booth Reviewed-By: Jacob Smith Reviewed-By: Mestery -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 15 Apr 2022 23:32:28 GMT ✔ Approvals: 3 ✔ - Geoffrey Booth (@GeoffreyBooth): https://github.com/nodejs/node/pull/42753#pullrequestreview-943891795 ✔ - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/42753#pullrequestreview-943919035 ✔ - Mestery (@Mesteery): https://github.com/nodejs/node/pull/42753#pullrequestreview-943983208 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 42753 From https://github.com/nodejs/node * branch refs/pull/42753/merge -> FETCH_HEAD ✔ Fetched commits as 1e761654d3d9..79261a5ba49a -------------------------------------------------------------------------------- [master ccf5bc3d7e] doc: clarify core modules that can be loaded without a prefix Author: Antoine du Hamel Date: Sat Apr 16 01:30:35 2022 +0200 1 file changed, 8 insertions(+), 5 deletions(-) [master 8d50e21ad5] Update doc/api/modules.md Author: Antoine du Hamel Date: Sat Apr 16 14:48:29 2022 +0200 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/2192673947 |
Landed in 1fe5d56 |
Refs: nodejs#42325 PR-URL: nodejs#42753 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Mestery <mestery@protonmail.com>
Refs: nodejs/node#42325 PR-URL: nodejs/node#42753 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Mestery <mestery@protonmail.com>
Refs: #42325